Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test-debugger-scripts to use await/async #44692

Merged
merged 5 commits into from
Sep 29, 2022
Merged

test: update test-debugger-scripts to use await/async #44692

merged 5 commits into from
Sep 29, 2022

Conversation

mmeenapriya
Copy link
Contributor

Signed-off-by: MeenaPriya Meenakshisundaram mmeenapriya@gmail.com

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 16, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@Trott Trott force-pushed the mmeenapriya-patch-1 branch from c949ae5 to 30acf2d Compare September 26, 2022 22:23
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46840/

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@Trott Trott force-pushed the mmeenapriya-patch-1 branch from 30acf2d to d9bad3d Compare September 28, 2022 21:23
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46910/

@github-actions github-actions bot mentioned this pull request Sep 29, 2022
Open
16 tasks
@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 29, 2022
@Trott Trott force-pushed the mmeenapriya-patch-1 branch from d9bad3d to c8d0106 Compare September 29, 2022 02:57
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46916/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46939/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46944/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit 29c35ea into nodejs:main Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 29c35ea

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@Trott
Copy link
Member

Trott commented Sep 29, 2022

Thanks for the contribution! 🎉

This was referenced Sep 30, 2022
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@mmeenapriya @danielleadams
test: update test-debugger-scripts to use await/async
8033ad8 
PR-URL: #44692
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmeenapriya @nodejs-github-bot @Trott @panva