Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove Legacy status from querystring #44912

Merged
merged 2 commits into from
Oct 9, 2022
Merged

doc: remove Legacy status from querystring #44912

merged 2 commits into from
Oct 9, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 7, 2022

Closes: #44911

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module. labels Oct 7, 2022
@Trott Trott mentioned this pull request Oct 7, 2022
Closed
mcollina
mcollina approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos
Copy link
Member

targos commented Oct 7, 2022 •
edited
Loading

I'm not able to check who moved that API to Legacy but we should probably ping them.

@anonrig
Copy link
Member

anonrig commented Oct 7, 2022

I'm in favor of removing legacy and improving querystring module performance.

@Trott
Copy link
Member Author

Trott commented Oct 7, 2022

I'm not able to check who moved that API to Legacy but we should probably ping them.

It was @jasnell in 32ade6997ba.

@jasnell
Copy link
Member

jasnell commented Oct 8, 2022

I'm -0 on this. I don't see much justification. Legacy status doesn't mean we can't take improvements at all. Won't block tho.

@targos
Copy link
Member

targos commented Oct 8, 2022

@jasnell see #44911. The problem is that many people confuse Legacy and Deprecated.

@kibertoad
Copy link
Contributor

@jasnell if it doesn't mean it can't be improved, and it doesn't mean there are strong reasons not to use it in the new code, then what does it even mean?

@jasnell
Copy link
Member

jasnell commented Oct 8, 2022

@targos yeah that's why I'm not blocking :-)

@kibertoad ... It means there is a standard API alternative available that is preferred, which for me (at least) counts as a strong reason not to use it.

@kibertoad
Copy link
Contributor

@jasnell but can it be called a clearly preferred alternative? it is both slower and handles significantly less cases. it's basically a glorified toString

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2022
@jasnell
Copy link
Member

jasnell commented Oct 9, 2022

@kibertoad ... We are all welcomed to our own opinions. I did clearly state that mine was non-blocking. I think legacy status is better here and legacy doesn't mean that continued improvement cannot be made.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit c163bf9 into nodejs:main Oct 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in c163bf9

@Trott Trott deleted the querystring branch October 9, 2022 16:05
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@Trott @danielleadams
doc: remove Legacy status from querystring
842bc64 
Closes: #44911
PR-URL: #44912
Fixes: #44911
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@ErickWendel ErickWendel ErickWendel approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove legacy status from querystring