Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: handle no support for external buffers #45181

Closed
wants to merge 11 commits into from
Closed

node-api: handle no support for external buffers #45181

wants to merge 11 commits into from

Commits on Oct 25, 2022

  1. node-api: handle no support for external buffers 

    Refs: electron/electron#35801
Refs: nodejs/abi-stable-node#441

Electron recently dropped support for external
buffers. Provide a way for addon authors to:
- hide the methods to create external buffers so they can
  avoid using them if they want the broadest compatibility.
- call the methods that create external buffers at runtime
  to check if external buffers are supported and either
  use them or not based on the return code.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    e29b2c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Update doc/api/n-api.md 

    Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
    @mhdawson @legendecas
    mhdawson and legendecas authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9d67a66 View commit details
    Browse the repository at this point in the history

  2. Update n-api.md

    @mhdawson
    mhdawson authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    ac56ab0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Update js_native_api.h

    @mhdawson
    mhdawson authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    5ba9934 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. squash: address review comments 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ebefb2b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Update doc/api/n-api.md 

    Co-authored-by: Robert Nagy <ronagy@icloud.com>
    @mhdawson @ronag
    mhdawson and ronag authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    a8038ac View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. squash: switch define used to check for cage 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    e66382b View commit details
    Browse the repository at this point in the history

  2. address review comments

    @mhdawson
    mhdawson authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    15a43d6 View commit details
    Browse the repository at this point in the history

  3. address review comments

    @mhdawson
    mhdawson authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d3f0252 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. squash: address review comments

    @mhdawson
    mhdawson authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    874cac1 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. squash: address comments 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    981f9ae View commit details
    Browse the repository at this point in the history