Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cleanup on disambiguating native modules #45665

Closed
wants to merge 2 commits into from
Closed

src: cleanup on disambiguating native modules #45665

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson
src: cleanup on disambiguating native modules
1f7e71f 
Found while backporting
nodejs#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 28, 2022
mhdawson
mhdawson commented Nov 28, 2022
View reviewed changes
src/env.cc Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member Author

@joyeecheung FYI

@mhdawson mhdawson added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48263/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48270/

@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Open
10 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48275/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48279/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48280/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48281/

mhdawson added a commit that referenced this pull request Dec 2, 2022
@mhdawson
src: cleanup on disambiguating native modules
22c645d 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Dec 2, 2022

Landed in 22c645d

@mhdawson mhdawson closed this Dec 2, 2022
This was referenced Dec 3, 2022
Open
Open
Open
Open
Open
This was referenced Dec 9, 2022
Open
Open
targos pushed a commit that referenced this pull request Dec 12, 2022
@mhdawson @targos
src: cleanup on disambiguating native modules
79edf25 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Dec 12, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@mhdawson @danielleadams
src: cleanup on disambiguating native modules
afe45d4 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@mhdawson @danielleadams
src: cleanup on disambiguating native modules
d4155a2 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@mhdawson @danielleadams
src: cleanup on disambiguating native modules
29f2dab 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@mhdawson @danielleadams
src: cleanup on disambiguating native modules
f9ba8ca 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@mhdawson @danielleadams
src: cleanup on disambiguating native modules
edcb31d 
Found while backporting
#45663

Fixup one rename missed

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #45665
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@legendecas legendecas legendecas approved these changes

@daeyeon daeyeon daeyeon approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhdawson @nodejs-github-bot @addaleax @lpinca @anonrig @daeyeon @legendecas @VoltrexKeyva