Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix readable stream as async iterator function #46147

Merged
merged 3 commits into from
Jan 20, 2023
Merged

stream: fix readable stream as async iterator function #46147

merged 3 commits into from
Jan 20, 2023

Commits on Jan 9, 2023

  1. stream: fix readable stream as async iterator function 

    Since v19.2 it's not possible to use readableStreams
as async iterators (confirmed bug).
This patch fixes the problem by reading the Stream.Duplex property
from 'streams/duplex' instead of 'streams/legacy' module

Fixes: nodejs#46141
    @ErickWendel
    ErickWendel committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    0e07fc8 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. stream: rollback duplex from new api

    @ErickWendel
    ErickWendel committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    47ca37d View commit details
    Browse the repository at this point in the history

  2. stream: load stream module when using stream/promises

    @ErickWendel
    ErickWendel committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    88a656a View commit details
    Browse the repository at this point in the history