From baa38ddba973f5b04154bbd4ce97c87f2a036f8e Mon Sep 17 00:00:00 2001 From: "Vladimir Morozov (REDMOND)" Date: Mon, 16 Jan 2023 13:21:18 -0800 Subject: [PATCH 1/3] build: fix MSVC 2022 Release compilation --- tools/v8_gypfiles/v8.gyp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index 868115e676f8b0..89330aa261ac6b 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -1433,6 +1433,14 @@ ['want_separate_host_toolset', { 'toolsets': ['host'], }], + ['OS=="win"', { + 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', + 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', + 'sources': [ + '<(_msvs_precompiled_header)', + '<(_msvs_precompiled_source)', + ], + }], ], }, # mksnapshot { From 2de21bde51f5c9d4da13d24a1e3e1627e04879bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 11 Jan 2023 08:44:50 +0000 Subject: [PATCH 2/3] tools: enable windows-2022 in actions --- .github/workflows/build-windows.yml | 2 +- .github/workflows/coverage-windows.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index e00e6457782407..64eb7ddad23988 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -34,7 +34,7 @@ jobs: if: github.event.pull_request.draft == false strategy: matrix: - windows: [windows-2019] + windows: [windows-2019, windows-2022] fail-fast: false runs-on: ${{ matrix.windows }} steps: diff --git a/.github/workflows/coverage-windows.yml b/.github/workflows/coverage-windows.yml index 5c127eb482d2f7..3dd8d01565c8cb 100644 --- a/.github/workflows/coverage-windows.yml +++ b/.github/workflows/coverage-windows.yml @@ -37,7 +37,7 @@ permissions: jobs: coverage-windows: if: github.event.pull_request.draft == false - runs-on: windows-2019 + runs-on: windows-2022 steps: - uses: actions/checkout@v3 with: From ffe17f83a85deb58249aa7bf038edc7178aba779 Mon Sep 17 00:00:00 2001 From: Vladimir Morozov Date: Sat, 21 Jan 2023 13:07:44 -0800 Subject: [PATCH 3/3] resolve access violation error for MARMASM --- tools/v8_gypfiles/directory.build.props | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 tools/v8_gypfiles/directory.build.props diff --git a/tools/v8_gypfiles/directory.build.props b/tools/v8_gypfiles/directory.build.props new file mode 100644 index 00000000000000..f0fdb0f39454fa --- /dev/null +++ b/tools/v8_gypfiles/directory.build.props @@ -0,0 +1,10 @@ + + + + + + $(IntDir)%(FileName)%(Extension).pp + + +