Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] src: use CreateEnvironment instead of inlining its code where possible #46330

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] src: use CreateEnvironment instead of inlining its code where possible #46330

wants to merge 1 commit into from

Commits on Feb 24, 2023

  1. src: use CreateEnvironment instead of inlining its code where possible 

    We had a number of places in which we created an `Environment` instance
by performing each step in `CreateEnvironment` manually. Instead,
just call the function itself.

PR-URL: nodejs#45886
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @addaleax @juanarbol
    addaleax authored and juanarbol committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    481bbb4 View commit details
    Browse the repository at this point in the history