-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading Windows on ARM64 to a tier 2 platform #47233
Upgrading Windows on ARM64 to a tier 2 platform #47233
Conversation
Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: nodejs#25998
+1, this would be great to see windows-arm64 supported in NodeJS! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1. All things considered I would recommend we target v20.0.0.
tagging @nodejs/releasers for visibility |
Great! Looking forward to the release |
@StefanStojanovic Can you summarise what is now in place to support this in terms of infrastructure? I haven't seen any of the details other than hearing that you've added some extra machines (From Azure?) into the CI. |
Certainly, here is the list of things we've done so far regarding the infrastructure:
ARM64 binaries are still cross-compiled from Windows x64, the same as before, so there are no additional machines for building neither in test nor in release CI. |
@mcollina we would certainly like to have this ready before Node v20! Do you mean that as well or do you see any reason why this shouldn't happen in v19? |
No specific reason! Go ahead for v19. |
@nodejs/releasers FYI |
Is there something else I can do to help this move forward? |
@mcollina @richardlau @lpinca since I can neither start the CI (not sure it's needed for this change) nor land a PR, could someone of you move this forward? |
It isn't as it is a doc only change. |
Landed in dad0b07 |
Thank you everyone for helping push this across the finish line! |
Awesome! |
Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/build#3046 Refs: nodejs/build#2540 Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS I cannot add a This is my suggestion for the notable-change text: Official support for ARM64 Windows Node.js now includes binaries for ARM64 Windows, allowing for native execution on the platform. The MSI, zip/7z packages, and executable are available from the Node.js download site along with all other platforms. The CI system was updated and all changes are now fully tested on ARM64 Windows, to prevent regressions and ensure compatibility. ARM64 Windows was upgraded to tier 2 support by Stefan Stojanovic on #47233. |
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. |
Official support for ARM64 Windows is something many people have been looking forward to for years. We recently added test machines to Jenkins, and tests are being run for every PR. We would like to move forward and move ARM64 Windows to tier 2.
@nodejs/build if this PR is approved, @joaocgreis and I will add arm64 to the release Jenkins to start producing releases.
This should land on v19. Node v18 and prior versions have failing tests.
cc @nodejs/tsc @nodejs/platform-windows @nodejs/platform-windows-arm
Refs: nodejs/build#3046
Refs: nodejs/build#2540
Fixes: #25998