test: move more inspector sequential tests to parallel #47412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which makes it possible to run the tests that use this in parallel.
Which makes it possible to run it in parallel.
Which makes it possible to run it in parallel.
This moves sequential inspector tests that can be run in parallel (using random ports) to parallel. Before: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:07|% 100|+ 28|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 26|- 0]: Done All tests passed. ``` After: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:00|% 100|+ 1|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 53|- 0]: Done All tests passed. ```
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Apr 5, 2023
MoLow
approved these changes
Apr 5, 2023
targos
approved these changes
Apr 5, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Apr 5, 2023
lpinca
approved these changes
Apr 5, 2023
Trott
approved these changes
Apr 7, 2023
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47412
✔ Done loading data for nodejs/node/pull/47412
----------------------------------- PR info ------------------------------------
Title test: move more inspector sequential tests to parallel (#47412)
Author Joyee Cheung (@joyeecheung)
Branch joyeecheung:inspector-tests -> nodejs:main
Labels test, needs-ci
Commits 4
- test: use random port in NodeInstance.startViaSignal()
- test: use random port in test-inspector-debug-brk-flag
- test: use random port in test-inspector-enabled
- test: move more inspector sequential tests to parallel
Committers 1
- Joyee Cheung
PR-URL: https://github.com/nodejs/node/pull/47412
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Yagiz Nizipli
Reviewed-By: Moshe Atlow
Reviewed-By: Michaël Zasso
Reviewed-By: Colin Ihrig
Reviewed-By: Luigi Pinca
Reviewed-By: Rich Trott
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47412
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Yagiz Nizipli
Reviewed-By: Moshe Atlow
Reviewed-By: Michaël Zasso
Reviewed-By: Colin Ihrig
Reviewed-By: Luigi Pinca
Reviewed-By: Rich Trott
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 04 Apr 2023 23:28:02 GMT
✔ Approvals: 6
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47412#pullrequestreview-1371960633
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47412#pullrequestreview-1372159757
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47412#pullrequestreview-1372460518
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47412#pullrequestreview-1373087924
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47412#pullrequestreview-1373566393
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47412#pullrequestreview-1376408341
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-04-06T21:25:24Z: https://ci.nodejs.org/job/node-test-pull-request/51023/
- Querying data for job/node-test-pull-request/51023/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 47412
From https://github.com/nodejs/node
* branch refs/pull/47412/merge -> FETCH_HEAD
✔ Fetched commits as 217830da9aa1..db0096c1862a
--------------------------------------------------------------------------------
[main f16d20cc02] test: use random port in NodeInstance.startViaSignal()
Author: Joyee Cheung
Date: Wed Apr 5 01:18:30 2023 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
[main 0b55d145b4] test: use random port in test-inspector-debug-brk-flag
Author: Joyee Cheung
Date: Wed Apr 5 01:20:49 2023 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
[main 15ced1e649] test: use random port in test-inspector-enabled
Author: Joyee Cheung
Date: Wed Apr 5 01:22:47 2023 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
[main 7d844b591d] test: move more inspector sequential tests to parallel
Author: Joyee Cheung
Date: Wed Apr 5 01:24:04 2023 +0200
28 files changed, 0 insertions(+), 0 deletions(-)
rename test/{sequential => parallel}/test-inspector-async-call-stack-abort.js (100%)
rename test/{sequential => parallel}/test-inspector-async-call-stack.js (100%)
rename test/{sequential => parallel}/test-inspector-async-hook-setup-at-inspect-brk.js (100%)
rename test/{sequential => parallel}/test-inspector-async-hook-setup-at-signal.js (100%)
rename test/{sequential => parallel}/test-inspector-async-stack-traces-promise-then.js (100%)
rename test/{sequential => parallel}/test-inspector-async-stack-traces-set-interval.js (100%)
rename test/{sequential => parallel}/test-inspector-break-e.js (100%)
rename test/{sequential => parallel}/test-inspector-break-when-eval.js (100%)
rename test/{sequential => parallel}/test-inspector-console.js (100%)
rename test/{sequential => parallel}/test-inspector-contexts.js (100%)
rename test/{sequential => parallel}/test-inspector-debug-brk-flag.js (100%)
rename test/{sequential => parallel}/test-inspector-debug-end.js (100%)
rename test/{sequential => parallel}/test-inspector-enabled.js (100%)
rename test/{sequential => parallel}/test-inspector-exception.js (100%)
rename test/{sequential => parallel}/test-inspector-has-inspector-false.js (100%)
rename test/{sequential => parallel}/test-inspector-invalid-args.js (100%)
rename test/{sequential => parallel}/test-inspector-ip-detection.js (100%)
rename test/{sequential => parallel}/test-inspector-not-blocked-on-idle.js (100%)
rename test/{sequential => parallel}/test-inspector-open.js (100%)
rename test/{sequential => parallel}/test-inspector-overwrite-config.js (100%)
rename test/{sequential => parallel}/test-inspector-port-zero.js (100%)
rename test/{sequential => parallel}/test-inspector-resource-name-to-url.js (100%)
rename test/{sequential => parallel}/test-inspector-runtime-evaluate-with-timeout.js (100%)
rename test/{sequential => parallel}/test-inspector-scriptparsed-context.js (100%)
rename test/{sequential => parallel}/test-inspector-stop-profile-after-done.js (100%)
rename test/{sequential => parallel}/test-inspector-stops-no-file.js (100%)
rename test/{sequential => parallel}/test-inspector-stress-http.js (100%)
rename test/{sequential => parallel}/test-inspector.js (100%)
✔ Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/8)
https://github.com/nodejs/node/actions/runs/4640033372 |
lpinca
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 217830d...7ece9f3 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Which makes it possible to run the tests that use this in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Which makes it possible to run it in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Which makes it possible to run it in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
This moves sequential inspector tests that can be run in parallel (using random ports) to parallel. Before: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:07|% 100|+ 28|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 26|- 0]: Done All tests passed. ``` After: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:00|% 100|+ 1|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 53|- 0]: Done All tests passed. ``` PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Which makes it possible to run the tests that use this in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Which makes it possible to run it in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Which makes it possible to run it in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
This moves sequential inspector tests that can be run in parallel (using random ports) to parallel. Before: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:07|% 100|+ 28|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 26|- 0]: Done All tests passed. ``` After: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:00|% 100|+ 1|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 53|- 0]: Done All tests passed. ``` PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Which makes it possible to run the tests that use this in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Which makes it possible to run it in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Which makes it possible to run it in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This moves sequential inspector tests that can be run in parallel (using random ports) to parallel. Before: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:07|% 100|+ 28|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 26|- 0]: Done All tests passed. ``` After: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:00|% 100|+ 1|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 53|- 0]: Done All tests passed. ``` PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Which makes it possible to run the tests that use this in parallel. PR-URL: nodejs#47412 Refs: nodejs#47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Which makes it possible to run it in parallel. PR-URL: nodejs#47412 Refs: nodejs#47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Which makes it possible to run it in parallel. PR-URL: nodejs#47412 Refs: nodejs#47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This moves sequential inspector tests that can be run in parallel (using random ports) to parallel. Before: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:07|% 100|+ 28|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 26|- 0]: Done All tests passed. ``` After: ``` ❯ tools/test.py "test/sequential/test-inspector-*" [00:00|% 100|+ 1|- 0]: Done All tests passed. ❯ tools/test.py "test/parallel/test-inspector-*" [00:01|% 100|+ 53|- 0]: Done All tests passed. ``` PR-URL: nodejs#47412 Refs: nodejs#47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves sequential inspector tests that can be run in
parallel (using random ports) to parallel.
Before:
After:
Refs: #47146