Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update ada to 2.4.0 #47922

Merged
merged 1 commit into from
May 9, 2023
Merged

deps: update ada to 2.4.0 #47922

merged 1 commit into from
May 9, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented May 8, 2023 •
edited by anonrig
Loading

This is an automated update of ada to 2.4.0.

Fixes #47894

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented May 8, 2023 •
edited by anonrig
Loading

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig
Copy link
Member

anonrig commented May 8, 2023

cc @RaisinTen @bnoordhuis @tniessen

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51703/

@anonrig anonrig mentioned this pull request May 8, 2023
Closed
@github-actions github-actions bot mentioned this pull request May 9, 2023
Open
29 tasks
RaisinTen
RaisinTen approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit a6ad5d8 into main May 9, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in a6ad5d8

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch May 9, 2023 15:53
@github-actions github-actions bot mentioned this pull request May 10, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@nodejs-github-bot @targos
deps: update ada to 2.4.0
c2b14b4 
PR-URL: #47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@anonrig anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
dc8c9c6 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
7abb0bc 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
82221be 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@anonrig anonrig added the backport-open-v18.x Indicate that the PR has an open backport. label Jun 5, 2023
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 17, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
9ae463c 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 23, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
5f591c2 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
fc0d7a8 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
b82e2b9 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
208931a 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
f53b50c 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
93fd394 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
1facb0b 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
461c1e9 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.4.0
81b514d 
PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ada's license
6 participants
@nodejs-github-bot @anonrig @lemire @lpinca @RaisinTen @danielleadams