tools: add support for subkeys in release tools #4807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
force-pushed
the
support-sub-keys
branch
from
3c6a93f
to
af1f38c
Compare
MylesBorins
force-pushed
the
support-sub-keys
branch
from
af1f38c
to
3bf7733
Compare
| @@ -20,7 +20,7 @@ signcmd=dist-sign | |||
|
|
|||
| echo "# Selecting GPG key ..." | |||
|
|
|||
| gpgkey=$(gpg --list-secret-keys | grep '^sec' | awk -F'( +|/)' '{print $3}') | |||
| gpgkey=$(gpg --list-secret-keys | grep -E '^sec|^ssb' | awk -F'( +|/)' '{print $3}') | |||
There was a problem hiding this comment.
I'm not 100% we want to be using the -E flag here. Personally I don't see a problem, but perhaps we want to solve this without using an extended regular expression
|
As a note, my subkey works, but it always prints the |
|
Any thoughts on this @rvagg ? |
|
Yeah, this works, I was working up a complicated solution in my head but the fact that this simply prompts you to choose makes it a simple fix! Good thinking.
lgtm with that change. |
MylesBorins
force-pushed
the
support-sub-keys
branch
from
3bf7733
to
403659f
Compare
MylesBorins
force-pushed
the
support-sub-keys
branch
from
403659f
to
c219ad1
Compare
|
@rvagg I added the change and rebased against master |
MylesBorins
force-pushed
the
support-sub-keys
branch
from
c219ad1
to
726bea7
Compare
|
lgtm, I think you can probably land this at will now, thanks @thealphanerd! |
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Jan 26, 2016
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
|
Landed in 321162d |
MylesBorins
force-pushed
the
support-sub-keys
branch
from
726bea7
to
321162d
Compare
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2016
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins
added a commit
that referenced
this pull request
Jan 28, 2016
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Feb 13, 2016
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 18, 2022
This was referenced Oct 19, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace grep with awk to add support for subkeys
/cc @rvagg @jasnell @Fishrock123 @nodejs/build