From 492891ede9da641fd3d42e74d14f0740096d1ed0 Mon Sep 17 00:00:00 2001 From: Ram Date: Fri, 22 Sep 2023 18:29:42 -0400 Subject: [PATCH 1/4] Replace forEach with for loop --- test/parallel/test-dgram-socket-buffer-size.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-dgram-socket-buffer-size.js b/test/parallel/test-dgram-socket-buffer-size.js index c03b8bf48b0221..1c23ab8e320994 100644 --- a/test/parallel/test-dgram-socket-buffer-size.js +++ b/test/parallel/test-dgram-socket-buffer-size.js @@ -93,17 +93,19 @@ function getExpectedError(type) { const socket = dgram.createSocket('udp4'); socket.bind(common.mustCall(() => { - badBufferSizes.forEach((badBufferSize) => { + for (let i = 0; i < badBufferSizes.length; i++) { + const badBufferSize = badBufferSizes[i]; + assert.throws(() => { socket.setRecvBufferSize(badBufferSize); }, errorObj); - + assert.throws(() => { socket.setSendBufferSize(badBufferSize); }, errorObj); - }); + } socket.close(); - })); + })); } { From bdda894f1928455381863a1d578a4ac48d2bbc05 Mon Sep 17 00:00:00 2001 From: Ram Date: Fri, 22 Sep 2023 18:53:54 -0400 Subject: [PATCH 2/4] uses for... loop instead of index based loop --- test/parallel/test-dgram-socket-buffer-size.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/parallel/test-dgram-socket-buffer-size.js b/test/parallel/test-dgram-socket-buffer-size.js index 1c23ab8e320994..a021dfe028eea1 100644 --- a/test/parallel/test-dgram-socket-buffer-size.js +++ b/test/parallel/test-dgram-socket-buffer-size.js @@ -93,9 +93,7 @@ function getExpectedError(type) { const socket = dgram.createSocket('udp4'); socket.bind(common.mustCall(() => { - for (let i = 0; i < badBufferSizes.length; i++) { - const badBufferSize = badBufferSizes[i]; - + for (const badBufferSize of badBufferSizes) { assert.throws(() => { socket.setRecvBufferSize(badBufferSize); }, errorObj); From c6b663394929475358f7065c7fab541215f2a962 Mon Sep 17 00:00:00 2001 From: Ram Date: Fri, 22 Sep 2023 19:00:22 -0400 Subject: [PATCH 3/4] Remove trailing spaces --- test/parallel/test-dgram-socket-buffer-size.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-dgram-socket-buffer-size.js b/test/parallel/test-dgram-socket-buffer-size.js index a021dfe028eea1..eca46ae521b4b2 100644 --- a/test/parallel/test-dgram-socket-buffer-size.js +++ b/test/parallel/test-dgram-socket-buffer-size.js @@ -97,7 +97,6 @@ function getExpectedError(type) { assert.throws(() => { socket.setRecvBufferSize(badBufferSize); }, errorObj); - assert.throws(() => { socket.setSendBufferSize(badBufferSize); }, errorObj); From 8f062fe73055e6b3bee841699d23e8d0a72902eb Mon Sep 17 00:00:00 2001 From: Ram Date: Fri, 22 Sep 2023 19:01:33 -0400 Subject: [PATCH 4/4] Remove extra spaces --- test/parallel/test-dgram-socket-buffer-size.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-dgram-socket-buffer-size.js b/test/parallel/test-dgram-socket-buffer-size.js index eca46ae521b4b2..fcc492a958215c 100644 --- a/test/parallel/test-dgram-socket-buffer-size.js +++ b/test/parallel/test-dgram-socket-buffer-size.js @@ -102,7 +102,7 @@ function getExpectedError(type) { }, errorObj); } socket.close(); - })); + })); } {