-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix inconsistent styling #4996
Conversation
is not in the root certificates list. (You could provide an issuer via `ca` | ||
option.) | ||
NOTE: `issuer` could be `null`, if the certificate is self-signed or if the | ||
issuer is not in the root certificates list. (You could provide an issuer via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, while you're in there: Remove personal pronoun.
Before:
You could provide an issuer via
ca
option.
After, something like:
An issuer may be provided via the
ca
option.
LGTM with a take-it-or-leave-it nit. |
LGTM |
LGTM with nit addressed |
3bcc34f
to
cad34b3
Compare
Wording changed as suggested. |
LGTM |
2 similar comments
LGTM |
LGTM |
PR-URL: #4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 01dd8ed |
PR-URL: #4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The changes in this are fairly minor, not landing cleanly, and bringing over other changes. I'm changing to dont-land for now. Please feel free to manually backport or get the conversation going again |
PR-URL: nodejs#4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
No description provided.