Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fallback to readFileSync when source is nullish #50825

Merged
merged 5 commits into from
Nov 29, 2023
Merged

esm: fallback to readFileSync when source is nullish #50825

merged 5 commits into from
Nov 29, 2023

Commits on Nov 20, 2023

  1. esm: fallback to getSource when load returns nullish source 

    When using the Modules Customization Hooks API to load CommonJS modules,
we want to support the returned value of `defaultLoad` which must be
nullish to preserve backward compatibility. This can be achieved by
fetching the source from the translator.
    @aduh95
    aduh95 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e1f1a80 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. fixup! esm: fallback to getSource when load returns nullish source

    @aduh95
    aduh95 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    11c610a View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Apply suggestions from code review

    @aduh95
    aduh95 authored Nov 25, 2023
    Configuration menu
    Copy the full SHA
    b58772c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. remove weird condition

    @aduh95
    aduh95 committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a359b02 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. fixup! remove weird condition

    @aduh95
    aduh95 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3cde424 View commit details
    Browse the repository at this point in the history