build: use clang over g++ for ubsan

[H4ad]

Use clang instead of g++ as we do for test-asan since it appears to use less memory, and probably should build faster too, refs: #32776

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[targos]

Need #52152 otherwise ubsan doesn't run on the PR

[targos]

It landed so you can rebase on main now

[targos]

LGTM if it works.

[targos]

Run without this PR for comparison: https://github.com/nodejs/node/actions/runs/8372351086/job/22923148679

[H4ad]

It took less time to compile, but it took much longer to test and it broke.

I don't have much knowledge on this topic, so do you think there's something we can do to try and fix it, or does ubsan only work with g++?

[anonrig]

@lemire maybe has some knowledge on this

[lemire]

To my knowledge, ubsan works with both clang and gcc.

[lemire]

@H4ad Does it work locally for you, or does it only fail in CI?

[targos]

Here's part of the error log:

../deps/v8/src/api/api-arguments-inl.h:334:3: runtime error: call to function v8::internal::Accessors::ReconfigureToDataProperty(v8::Local<v8::Name>, v8::Local<v8::Value>, v8::PropertyCallbackInfo<v8::Boolean> const&) through pointer to incorrect function type 'void (*)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void> &)'
(/home/runner/work/node/node/out/Release/node+0x2e875b0): note: v8::internal::Accessors::ReconfigureToDataProperty(v8::Local<v8::Name>, v8::Local<v8::Value>, v8::PropertyCallbackInfo<v8::Boolean> const&) defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../deps/v8/src/api/api-arguments-inl.h:334:3 in 
../deps/v8/src/api/api-arguments-inl.h:334:3: runtime error: call to function v8::internal::Accessors::ReconfigureToDataProperty(v8::Local<v8::Name>, v8::Local<v8::Value>, v8::PropertyCallbackInfo<v8::Boolean> const&) through pointer to incorrect function type 'void (*)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void> &)'
(/home/runner/work/node/node/out/Release/node+0x2e875b0): note: v8::internal::Accessors::ReconfigureToDataProperty(v8::Local<v8::Name>, v8::Local<v8::Value>, v8::PropertyCallbackInfo<v8::Boolean> const&) defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../deps/v8/src/api/api-arguments-inl.h:334:3 in 
../deps/v8/src/handles/global-handles.cc:866:3: runtime error: call to function node::BaseObject::MakeWeak()::$_0::__invoke(v8::WeakCallbackInfo<node::BaseObject> const&) through pointer to incorrect function type 'void (*)(const v8::WeakCallbackInfo<void> &)'
(/home/runner/work/node/node/out/Release/node+0x24e8e90): note: node::BaseObject::MakeWeak()::$_0::__invoke(v8::WeakCallbackInfo<node::BaseObject> const&) defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../deps/v8/src/handles/global-handles.cc:866:3 in 
npm WARN cli npm v10.5.0 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)
../deps/base64/base64/lib/codec_choose.c:215:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../deps/base64/base64/lib/codec_choose.c:215:17 in

[lemire]

@targos One of those warnings is legitimate:

#ifndef bit_AVX512vl
#define bit_AVX512vl (1 << 31)
#endif

I don't think it is a bug per se because no compiler would do the wrong thing here. But it seems to indicate that the tool is doing its work.

[RafaelGSS]

clang doesn't accept specific operators for suppression files. That's why I switched to g++. Are the actions running out of memory?

[H4ad]

Does it work locally for you, or does it only fail in CI?

I just compiled locally but didn't try to run the tests for ubsan.

Are the actions running out of memory?

No, I just thought we could use clang to speed up/reduce memory usage based on another action that was using it.

That being the case, I will close this PR, thanks for the feedback!