From 0d38b1050037b4f5b06f5a0798c6e142d083e24d Mon Sep 17 00:00:00 2001 From: KaKa Date: Tue, 16 Apr 2024 10:50:09 +0800 Subject: [PATCH 1/6] doc: correct stream.finished changes --- doc/api/stream.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/api/stream.md b/doc/api/stream.md index 7439e51c1ac1ce..0c8b5868d05c13 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -237,6 +237,12 @@ The `pipeline` API provides [callback version][stream-pipeline]: * `stream` {Stream} From b6e62b7afc509edd4d12562e47dcc48ea5a4820a Mon Sep 17 00:00:00 2001 From: KaKa Date: Tue, 16 Apr 2024 10:57:53 +0800 Subject: [PATCH 2/6] fixup --- doc/api/stream.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index 0c8b5868d05c13..b1725919e401a5 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -242,10 +242,11 @@ changes: - v18.14.0 - v20.0.0 pr-url: https://github.com/nodejs/node/pull/46205 - description: Add support for ReadableStream and WritableStream + description: Added support for `ReadableStream` and `WritableStream`. --> -* `stream` {Stream} +* `stream` {Stream|ReadableStream|WritableStream} A readable and/or writable + stream/webstream. * `options` {Object} * `error` {boolean|undefined} * `readable` {boolean|undefined} From dcc2118d19362e3e13b5ffd148c53f53ba10370f Mon Sep 17 00:00:00 2001 From: KaKa Date: Tue, 16 Apr 2024 11:06:34 +0800 Subject: [PATCH 3/6] fixup --- doc/api/stream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index b1725919e401a5..bab85ef0137200 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -239,8 +239,8 @@ The `pipeline` API provides [callback version][stream-pipeline]: added: v15.0.0 changes: - version: - - v18.14.0 - v20.0.0 + - v18.14.0 pr-url: https://github.com/nodejs/node/pull/46205 description: Added support for `ReadableStream` and `WritableStream`. --> From 77ffc7ae7e8eddac2e244eb6686e15ff180bffa9 Mon Sep 17 00:00:00 2001 From: KaKa <23028015+climba03003@users.noreply.github.com> Date: Tue, 16 Apr 2024 17:03:29 +0800 Subject: [PATCH 4/6] fixup Co-authored-by: Luigi Pinca --- doc/api/stream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index bab85ef0137200..c66c6aa2e00eb9 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -239,7 +239,7 @@ The `pipeline` API provides [callback version][stream-pipeline]: added: v15.0.0 changes: - version: - - v20.0.0 + - v19.5.0 - v18.14.0 pr-url: https://github.com/nodejs/node/pull/46205 description: Added support for `ReadableStream` and `WritableStream`. From bb0854459254b60b829e5a6aa41f651487ca9bfc Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Tue, 16 Apr 2024 12:29:41 +0300 Subject: [PATCH 5/6] fixup! fix pr id --- doc/api/stream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index c66c6aa2e00eb9..fe0119efeb7c93 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -241,7 +241,7 @@ changes: - version: - v19.5.0 - v18.14.0 - pr-url: https://github.com/nodejs/node/pull/46205 + pr-url: https://github.com/nodejs/node/pull/52551 description: Added support for `ReadableStream` and `WritableStream`. --> From 39c7be33fbf45273cfdf5c2a2767517dad20b742 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Tue, 16 Apr 2024 12:30:57 +0300 Subject: [PATCH 6/6] fixup! revert --- doc/api/stream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index fe0119efeb7c93..c66c6aa2e00eb9 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -241,7 +241,7 @@ changes: - version: - v19.5.0 - v18.14.0 - pr-url: https://github.com/nodejs/node/pull/52551 + pr-url: https://github.com/nodejs/node/pull/46205 description: Added support for `ReadableStream` and `WritableStream`. -->