Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct stream.finished changes #52551

Merged
merged 6 commits into from
Apr 20, 2024
Merged

doc: correct stream.finished changes #52551

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d38b10
doc: correct stream.finished changes
climba03003 Apr 16, 2024
b6e62b7
fixup
climba03003 Apr 16, 2024
dcc2118
fixup
climba03003 Apr 16, 2024
77ffc7a
fixup
climba03003 Apr 16, 2024
bb08544
fixup! fix pr id
benjamingr Apr 16, 2024
39c7be3
fixup! revert
benjamingr Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,16 @@

<!-- YAML
added: v15.0.0
changes:
- version:
- v18.14.0
- v20.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3225498 shows it is added starting from v20.0.0
cde59606cd shows it is backported to v18.14.0

pr-url: https://github.com/nodejs/node/pull/46205

Check warning on line 244 in doc/api/stream.md

View workflow job for this annotation

GitHub Actions / lint-pr-url 

pr-url doesn't match the URL of the current PR.
benjamingr marked this conversation as resolved.
Show resolved Hide resolved
description: Added support for `ReadableStream` and `WritableStream`.
-->

* `stream` {Stream}
* `stream` {Stream|ReadableStream|WritableStream} A readable and/or writable
stream/webstream.
* `options` {Object}
* `error` {boolean|undefined}
* `readable` {boolean|undefined}
Expand Down
Loading