diff --git a/src/node_process_object.cc b/src/node_process_object.cc index 274f1f01de8d84..935a6c612d706a 100644 --- a/src/node_process_object.cc +++ b/src/node_process_object.cc @@ -13,7 +13,6 @@ namespace node { using v8::Context; -using v8::DEFAULT; using v8::EscapableHandleScope; using v8::Function; using v8::FunctionCallbackInfo; @@ -183,13 +182,12 @@ void PatchProcessObject(const FunctionCallbackInfo& args) { // process.title CHECK(process - ->SetAccessor( + ->SetNativeDataProperty( context, FIXED_ONE_BYTE_STRING(isolate, "title"), ProcessTitleGetter, env->owns_process_state() ? ProcessTitleSetter : nullptr, Local(), - DEFAULT, None, SideEffectType::kHasNoSideEffect) .FromJust()); @@ -208,9 +206,15 @@ void PatchProcessObject(const FunctionCallbackInfo& args) { READONLY_PROPERTY(process, "pid", Integer::New(isolate, uv_os_getpid())); - CHECK(process->SetAccessor(context, - FIXED_ONE_BYTE_STRING(isolate, "ppid"), - GetParentProcessId).FromJust()); + CHECK(process + ->SetNativeDataProperty(context, + FIXED_ONE_BYTE_STRING(isolate, "ppid"), + GetParentProcessId, + nullptr, + Local(), + None, + SideEffectType::kHasNoSideEffect) + .FromJust()); // --security-revert flags #define V(code, _, __) \ @@ -235,11 +239,14 @@ void PatchProcessObject(const FunctionCallbackInfo& args) { // process.debugPort CHECK(process - ->SetAccessor(context, - FIXED_ONE_BYTE_STRING(isolate, "debugPort"), - DebugPortGetter, - env->owns_process_state() ? DebugPortSetter : nullptr, - Local()) + ->SetNativeDataProperty( + context, + FIXED_ONE_BYTE_STRING(isolate, "debugPort"), + DebugPortGetter, + env->owns_process_state() ? DebugPortSetter : nullptr, + Local(), + None, + SideEffectType::kHasNoSideEffect) .FromJust()); } diff --git a/test/parallel/test-worker-unsupported-things.js b/test/parallel/test-worker-unsupported-things.js index 18c1617c3cde5e..95d93d24dec9f1 100644 --- a/test/parallel/test-worker-unsupported-things.js +++ b/test/parallel/test-worker-unsupported-things.js @@ -14,14 +14,16 @@ if (!process.env.HAS_STARTED_WORKER) { } else { { const before = process.title; - process.title += ' in worker'; - assert.strictEqual(process.title, before); + const after = before + ' in worker'; + process.title = after; + assert.strictEqual(process.title, after); } { const before = process.debugPort; - process.debugPort++; - assert.strictEqual(process.debugPort, before); + const after = before + 1; + process.debugPort = after; + assert.strictEqual(process.debugPort, after); } {