Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: fix TypedArray to a global type #54060

Closed
wants to merge 4 commits into from
Closed

typings: fix TypedArray to a global type #54060

wants to merge 4 commits into from

Conversation

1ilsang
Copy link
Contributor

@1ilsang 1ilsang commented Jul 26, 2024

image image
  1. Fixes invalid and unused declarations
  2. Fix TypedArray to a global type

anonrig
anonrig requested changes Jul 27, 2024
View reviewed changes
typings/globals.d.ts Outdated
| Uint32Array
| Int8Array
| Int16Array
| Int32Array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reduce your change to only to the goal of this pull request. It's really hard to review it right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig Thank you for your advice

I split it into b6f6827 and f606246 commits.

b6f6827 Main content of this PR, the Global type fix.

f606246 Applied the lint.

@1ilsang
Copy link
Contributor Author

1ilsang commented Jul 27, 2024

Split it into three PRs. #54063 #54064 #54065

@1ilsang 1ilsang closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig requested changes

Assignees
No one assigned
Labels
typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ilsang @anonrig @nodejs-github-bot