[v18.x] test: skip and mark flaky some tests #57001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Contributor
Author
|
Looks like the test is still failing, meaning it's not skipped at all, not sure why 🤔 |
Member
|
I think you edited |
marco-ippolito
approved these changes
Feb 11, 2025
github-actions
bot
removed
the
request-ci
Collaborator
richardlau
approved these changes
Feb 11, 2025
Member
|
FWIW test also failed on macOS 13: https://ci.nodejs.org/job/node-test-commit-osx/63642/nodes=osx13-x64/testReport/junit/(root)/sequential/test_perf_hooks/ |
aduh95
changed the title
test-perf-hooks on SmartOS
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
marco-ippolito
approved these changes
Feb 12, 2025
Contributor
Author
|
Any chance I could get the fast-track request approved? #57001 (comment) |
richardlau
approved these changes
Feb 12, 2025
Refs: nodejs#57000 PR-URL: nodejs#57001 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: nodejs#54803 PR-URL: nodejs#57001 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: nodejs#34730 PR-URL: nodejs#57001 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#57001 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: nodejs#50046 PR-URL: nodejs#57001 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
force-pushed
the
skip-test-perf-hook-smartos
branch
from
4d3f0bb to
06c523d
Compare
Contributor
Author
|
Landed in 8b8c9a2...06c523d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most those test have either been fixed in a semver-minor way on later release lines, or seems to not affect the other release lines for another reason.