From a72ab77c3292f1f4c30d1910bdf93c05b8d4a874 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Tue, 22 Jul 2025 14:04:49 -0300 Subject: [PATCH] benchmark: remove invalid-date on deepequal prims This benchmark file has been failing for a while when asserting invalid date. Considering asserting an invalid date is usually out of deepEqual performance scope. I propose to simply remove this. --- benchmark/assert/deepequal-prims-and-objs-big-loop.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/benchmark/assert/deepequal-prims-and-objs-big-loop.js b/benchmark/assert/deepequal-prims-and-objs-big-loop.js index 78622d96d832ec..bc2b84ebf20f41 100644 --- a/benchmark/assert/deepequal-prims-and-objs-big-loop.js +++ b/benchmark/assert/deepequal-prims-and-objs-big-loop.js @@ -22,7 +22,6 @@ const primValues = { 'empty_object': {}, 'regexp': /abc/i, 'date': new Date(), - 'invalidDate': new Date('foo'), }; const primValues2 = { @@ -35,7 +34,6 @@ const primValues2 = { 'empty_object': {}, 'regexp': /abc/i, 'date': new Date(primValues.date), - 'invalidDate': new Date('foo'), }; const primValuesUnequal = { @@ -51,7 +49,6 @@ const primValuesUnequal = { 'empty_object': [], 'regexp': /abc/g, 'date': new Date(primValues.date.getTime() + 1), - 'invalidDate': new Date(), }; const bench = common.createBenchmark(main, {