From 8c05d0ec8f05eddb3f2177b36a116f4aee3b38dd Mon Sep 17 00:00:00 2001 From: Filip Skokan Date: Wed, 30 Jul 2025 22:08:54 +0200 Subject: [PATCH] src: remove unused DSAKeyExportJob --- src/crypto/crypto_dsa.cc | 33 --------------------------------- src/crypto/crypto_dsa.h | 23 ----------------------- 2 files changed, 56 deletions(-) diff --git a/src/crypto/crypto_dsa.cc b/src/crypto/crypto_dsa.cc index eff34444999fbb..c2ae2eceb2cf2f 100644 --- a/src/crypto/crypto_dsa.cc +++ b/src/crypto/crypto_dsa.cc @@ -74,37 +74,6 @@ Maybe DsaKeyGenTraits::AdditionalConfig( return JustVoid(); } -Maybe DSAKeyExportTraits::AdditionalConfig( - const FunctionCallbackInfo& args, - unsigned int offset, - DSAKeyExportConfig* params) { - return JustVoid(); -} - -WebCryptoKeyExportStatus DSAKeyExportTraits::DoExport( - const KeyObjectData& key_data, - WebCryptoKeyFormat format, - const DSAKeyExportConfig& params, - ByteSource* out) { - CHECK_NE(key_data.GetKeyType(), kKeyTypeSecret); - - switch (format) { - case kWebCryptoKeyFormatRaw: - // Not supported for RSA keys of either type - return WebCryptoKeyExportStatus::FAILED; - case kWebCryptoKeyFormatPKCS8: - if (key_data.GetKeyType() != kKeyTypePrivate) - return WebCryptoKeyExportStatus::INVALID_KEY_TYPE; - return PKEY_PKCS8_Export(key_data, out); - case kWebCryptoKeyFormatSPKI: - if (key_data.GetKeyType() != kKeyTypePublic) - return WebCryptoKeyExportStatus::INVALID_KEY_TYPE; - return PKEY_SPKI_Export(key_data, out); - default: - UNREACHABLE(); - } -} - bool GetDsaKeyDetail(Environment* env, const KeyObjectData& key, Local target) { @@ -132,12 +101,10 @@ bool GetDsaKeyDetail(Environment* env, namespace DSAAlg { void Initialize(Environment* env, Local target) { DsaKeyPairGenJob::Initialize(env, target); - DSAKeyExportJob::Initialize(env, target); } void RegisterExternalReferences(ExternalReferenceRegistry* registry) { DsaKeyPairGenJob::RegisterExternalReferences(registry); - DSAKeyExportJob::RegisterExternalReferences(registry); } } // namespace DSAAlg } // namespace crypto diff --git a/src/crypto/crypto_dsa.h b/src/crypto/crypto_dsa.h index d761aad2ad02c7..784923c0abd227 100644 --- a/src/crypto/crypto_dsa.h +++ b/src/crypto/crypto_dsa.h @@ -36,29 +36,6 @@ struct DsaKeyGenTraits final { using DsaKeyPairGenJob = KeyGenJob>; -struct DSAKeyExportConfig final : public MemoryRetainer { - SET_NO_MEMORY_INFO() - SET_MEMORY_INFO_NAME(DSAKeyExportConfig) - SET_SELF_SIZE(DSAKeyExportConfig) -}; - -struct DSAKeyExportTraits final { - static constexpr const char* JobName = "DSAKeyExportJob"; - using AdditionalParameters = DSAKeyExportConfig; - - static v8::Maybe AdditionalConfig( - const v8::FunctionCallbackInfo& args, - unsigned int offset, - DSAKeyExportConfig* config); - - static WebCryptoKeyExportStatus DoExport(const KeyObjectData& key_data, - WebCryptoKeyFormat format, - const DSAKeyExportConfig& params, - ByteSource* out); -}; - -using DSAKeyExportJob = KeyExportJob; - bool GetDsaKeyDetail(Environment* env, const KeyObjectData& key, v8::Local target);