From 9df370139e22619efd1dfc944454afbd0fbc3552 Mon Sep 17 00:00:00 2001 From: meteorqz6 Date: Tue, 5 Aug 2025 03:11:06 +0900 Subject: [PATCH 1/2] typings: improve internal binding types - Add typing for 'encoding_binding' --- typings/globals.d.ts | 2 ++ typings/internalBinding/encoding_binding.d.ts | 8 ++++++++ 2 files changed, 10 insertions(+) create mode 100644 typings/internalBinding/encoding_binding.d.ts diff --git a/typings/globals.d.ts b/typings/globals.d.ts index 2ac9699b1f8d5b..e9875cdcc3bfa1 100644 --- a/typings/globals.d.ts +++ b/typings/globals.d.ts @@ -4,6 +4,7 @@ import { BlobBinding } from './internalBinding/blob'; import { ConfigBinding } from './internalBinding/config'; import { ConstantsBinding } from './internalBinding/constants'; import { DebugBinding } from './internalBinding/debug'; +import { EncodingBinding } from './internalBinding/encoding_binding'; import { HttpParserBinding } from './internalBinding/http_parser'; import { InspectorBinding } from './internalBinding/inspector'; import { FsBinding } from './internalBinding/fs'; @@ -34,6 +35,7 @@ interface InternalBindingMap { config: ConfigBinding; constants: ConstantsBinding; debug: DebugBinding; + encoding_binding: EncodingBinding; fs: FsBinding; fs_dir: FsDirBinding; http_parser: HttpParserBinding; diff --git a/typings/internalBinding/encoding_binding.d.ts b/typings/internalBinding/encoding_binding.d.ts new file mode 100644 index 00000000000000..55f551514444b4 --- /dev/null +++ b/typings/internalBinding/encoding_binding.d.ts @@ -0,0 +1,8 @@ +export interface EncodingBinding { + encodeInto(source: string, dest: Uint8Array): void; + encodeUtf8String(str: string): Uint8Array; + decodeUTF8(buffer: ArrayBufferView | ArrayBuffer | SharedArrayBuffer, ignoreBOM?: boolean, hasFatal?: boolean): string; + toASCII(input: string): string; + toUnicode(input: string): string; + decodeLatin1(buffer: ArrayBufferView | ArrayBuffer | SharedArrayBuffer, ignoreBOM?: boolean, hasFatal?: boolean): string; +} \ No newline at end of file From 643aec47f926cfcb0bc73eea0bf40f6c3177787c Mon Sep 17 00:00:00 2001 From: Nam Yooseong <102887277+meteorqz6@users.noreply.github.com> Date: Wed, 6 Aug 2025 13:10:56 +0900 Subject: [PATCH 2/2] Update typings/internalBinding/encoding_binding.d.ts Co-authored-by: Daeyeon Jeong --- typings/internalBinding/encoding_binding.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typings/internalBinding/encoding_binding.d.ts b/typings/internalBinding/encoding_binding.d.ts index 55f551514444b4..6e1d48efd81529 100644 --- a/typings/internalBinding/encoding_binding.d.ts +++ b/typings/internalBinding/encoding_binding.d.ts @@ -5,4 +5,4 @@ export interface EncodingBinding { toASCII(input: string): string; toUnicode(input: string): string; decodeLatin1(buffer: ArrayBufferView | ArrayBuffer | SharedArrayBuffer, ignoreBOM?: boolean, hasFatal?: boolean): string; -} \ No newline at end of file +}