Skip to content

build: only mention Apple when on Apple #59385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2025
Merged

build: only mention Apple when on Apple #59385

merged 1 commit into from
Aug 9, 2025

Conversation

@targos
Copy link
Member

@targos targos commented Aug 7, 2025

No description provided.

@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 7, 2025
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 7, 2025
@targos targos mentioned this pull request Aug 7, 2025
Closed
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68465/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68483/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68487/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit 7079041 into nodejs:main Aug 9, 2025
82 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 9, 2025

Landed in 7079041

@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos @nodejs-github-bot @lpinca @UlisesGascon @richardlau @legendecas @jakecastelli