From ad034005758ea19dbec03630d7570925f7b48c43 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Thu, 11 Sep 2025 17:38:44 +0200 Subject: [PATCH] deps: V8: cherry-pick 87356585659b Original commit message: [flags] Ignore memory tuning flags when computing hash for code caching Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261 Reviewed-by: Leszek Swirski Commit-Queue: Joyee Cheung Cr-Commit-Position: refs/heads/main@{#102443} Refs: https://github.com/v8/v8/commit/87356585659bb47bb2ce380a02d6820d6baaaf6b --- common.gypi | 2 +- deps/v8/src/flags/flags.cc | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 6dbe33f43f2d61..4906769afbd55b 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.7', + 'v8_embedder_string': '-node.8', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flags/flags.cc b/deps/v8/src/flags/flags.cc index db8ff5c67e16db..318f441161767c 100644 --- a/deps/v8/src/flags/flags.cc +++ b/deps/v8/src/flags/flags.cc @@ -477,6 +477,15 @@ uint32_t ComputeFlagListHash() { if (flag.PointsTo(&v8_flags.random_seed)) continue; if (flag.PointsTo(&v8_flags.predictable)) continue; + // These flags are not relevant for code caching and are often set by + // embedders to tune memory usage. + if (flag.PointsTo(&v8_flags.max_old_space_size) || + flag.PointsTo(&v8_flags.min_semi_space_size) || + flag.PointsTo(&v8_flags.max_semi_space_size) || + flag.PointsTo(&v8_flags.max_heap_size)) { + continue; + } + // The following flags are implied by --predictable (some negated). if (flag.PointsTo(&v8_flags.concurrent_sparkplug) || flag.PointsTo(&v8_flags.concurrent_recompilation) ||