crypto: ensure documented RSA-PSS saltLength default is used #60662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
confirmed-bug
Collaborator
|
Review requested:
|
tniessen
approved these changes
Nov 10, 2025
panva
added
the
author ready
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60662 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.02%
==========================================
Files 703 703
Lines 208077 208083 +6
Branches 40083 40081 -2
==========================================
- Hits 184254 184235 -19
- Misses 15841 15878 +37
+ Partials 7982 7970 -12
🚀 New features to boost your workflow:
|
Collaborator
aduh95
approved these changes
Nov 11, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2388991 |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2025
PR-URL: #60662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 18, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `25.2.0` -> `25.2.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.2.1`](https://github.com/nodejs/node/releases/tag/v25.2.1): 2025-11-17, Version 25.2.1 (Current), @​aduh95 [Compare Source](nodejs/node@v25.2.0...v25.2.1) This release reverts the spec-compliant behavior of sometimes throwing on `localStorage` access. We received feedback that this change on an experimental API was too breaking for a semver-minor release, so we decided to push it back for Node.js 26.0.0. ##### Commits - \[[`ff89b7b6c7`](nodejs/node@ff89b7b6c7)] - **crypto**: ensure documented RSA-PSS saltLength default is used (Filip Skokan) [#​60662](nodejs/node#60662) - \[[`5316b580eb`](nodejs/node@5316b580eb)] - **deps**: V8: backport [`2e4c5cf`](nodejs/node@2e4c5cf9b112) (Michaël Zasso) [#​60654](nodejs/node#60654) - \[[`ca878bc90e`](nodejs/node@ca878bc90e)] - **doc,src,lib**: clarify experimental status of Web Storage support (Antoine du Hamel) [#​60708](nodejs/node#60708) - \[[`a4dee613fd`](nodejs/node@a4dee613fd)] - ***Revert*** "**lib**: throw from localStorage getter on missing storage path" (Antoine du Hamel) [#​60750](nodejs/node#60750) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
targos
pushed a commit
that referenced
this pull request
Nov 18, 2025
PR-URL: #60662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2025
PR-URL: #60662 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the documented RSA-PSS saltLength default is used regardless of the OpenSSL version used by the runtime.