Skip to content

Conversation

@evanlucas
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The cluster docs had a period instead of a semicolon at the end of two
lines.

@evanlucas evanlucas added the doc Issues and PRs related to the documentations. label Apr 29, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can drop the \' in the middle too

@jasnell
Copy link
Member

jasnell commented Apr 29, 2016

LGTM with a nit

The cluster docs had a period instead of a semicolon at the end of two
lines.
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 29, 2016
@mscdex
Copy link
Contributor

mscdex commented Apr 29, 2016

LGTM

2 similar comments
@JacksonTian
Copy link
Contributor

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Apr 29, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 30, 2016
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: #6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 30, 2016

Landed in 4b0dda0

@jasnell jasnell closed this Apr 30, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: #6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: nodejs#6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants