Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fill in missing V8 version #7878

Closed
wants to merge 1 commit into from
Closed

doc: fill in missing V8 version #7878

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The CHANGELOG file contains a placeholder "5.0.71.xx" in reference to release 6.3.1's V8 version. Fill in the correct V8 version for that release, which is "5.0.71.57."

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 26, 2016
@addaleax
Copy link
Member

LGTM

@evanlucas
Copy link
Contributor

lgtm

@JungMinu
Copy link
Member

LGTM

2 similar comments
@mscdex
Copy link
Contributor

mscdex commented Jul 26, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Jul 29, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jul 29, 2016
PR-URL: #7878
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jul 29, 2016

Landed in 1896ca9. Thank you!

@jasnell jasnell closed this Jul 29, 2016
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
PR-URL: #7878
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants