Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: use system CAs instead of bundled ones #8334

Closed
wants to merge 3 commits into from

Commits on Dec 21, 2016

  1. crypto: do not use pointers to std::vector

    The pointer to std::vector is unnecessary, so replace it with standard
    instance. Also, make the for() loop more readable by using actual type
    instead of inferred - there is no readability benefit here from
    obfuscating the type.
    AdamMajer committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    0aa8ac7 View commit details
    Browse the repository at this point in the history
  2. crypto: Use system CAs instead of using bundled ones

    NodeJS can already use an external, shared OpenSSL library. This
    library knows where to look for OS managed certificates. Allow
    a compile-time option to use this CA store by default instead of
    using bundled certificates.
    
    In case when using bundled OpenSSL, the paths are also valid for
    majority of Linux systems without additional intervention. If
    this is not set, we can use SSL_CERT_DIR to point it to correct
    location.
    
    Fixes: nodejs#3159
    PR-URL: nodejs#8334
    AdamMajer committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    d1e0228 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Configuration menu
    Copy the full SHA
    1172288 View commit details
    Browse the repository at this point in the history