From dd13d71eb3ee34d84ca9059d40616bd0b44ca0ed Mon Sep 17 00:00:00 2001 From: cjihrig Date: Thu, 20 Oct 2016 12:34:09 -0400 Subject: [PATCH] child_process: remove unreachable execSync() code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code coverage showed that the execSync() variable inheritStderr was never set to the default value of true. This is because the default case is hit whenever normalizeExecArgs() returns an object without an 'options' property. However, this can never be the case because normalizeExecArgs() unconditionally creates the options object. This commit removes the unreachable code. PR-URL: https://github.com/nodejs/node/pull/9209 Reviewed-By: James M Snell Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Sakthipriyan Vairamani --- lib/child_process.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/child_process.js b/lib/child_process.js index 3cc6e2ce6a944e..4c2fb7e09817f4 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -517,7 +517,7 @@ exports.execFileSync = execFileSync; function execSync(command /*, options*/) { var opts = normalizeExecArgs.apply(null, arguments); - var inheritStderr = opts.options ? !opts.options.stdio : true; + var inheritStderr = !opts.options.stdio; var ret = spawnSync(opts.file, opts.options); ret.cmd = command;