add Node.js 10 LTS dubnium

[richardlau]

Refs: nodejs/node#23831 (comment)

[richardlau]

cc @nodejs/build

[MylesBorins]

Lgtm

[MylesBorins]

@nodejs/build what needs to be done to make this work?

[knksmith57]

after chasing around shell script call sites and previous GH issues, I think this is how it works:

1. when ansible bootstraps the build (and also web, and docs, and maybe everything?) instance, it globally installs nodejs-latest-linker

• https://github.com/nodejs/build/blob/f48fc38/setup/www/tasks/tools.yaml#L6

2. linker is called by promote_release.sh which is intended to be called by dist-promote on an ad-hoc basis by the release manager

• https://github.com/nodejs/build/blob/f48fc38/setup/www/tools/promote/promote_release.sh#L27
• https://github.com/nodejs/build/blob/f48fc38/setup/www/tools/dist/dist-promote#L17
• https://github.com/nodejs/build/blob/f48fc38/setup/www/tools/promote/README.md

Because the package is globally installed once and, unless I'm missing a scheduled updater somewhere, not upgraded again automatically, I think a release manager needs to shell onto the instance and bump the global install (or maybe re-run the playbook?).

It looks like Rod did something similar when Carbon was released: #1 (comment).

Definitely interested to hear from the build WG --at a minimum we could probably prefer to npx <pkg> for the globally-installed node deps to prevent this sort of manual intervention / version bumping.

[rvagg]

nicely deduced @knksmith57!

Getting this deployed and updated now. Unfortunately npx doesn't really solve the problem because the big hurdle is right here, getting the change in, merged and published. It's trivial for someone with publish access to also update on the server.

What might be a more interesting solution is for an update to nodejs-latest-linker that pulls down https://github.com/nodejs/Release/blob/master/schedule.json and uses that rather than having to take manual updates. Then there's not even an update required here.

[rvagg]

https://nodejs.org/download/release/latest-dubnium/ all done

[knksmith57]

ah, that makes sense --it didn't occur to me that most (all?) devs w/ publish perms for this package would also have shell access to the box.

thanks for following up and for handling the rollout 🙏

[knksmith57]

also, heads up @rvagg: looks like there's a cyclical symlink to v10.13.0 in the /download/release/latest-dubnium dir that we may want to prune --possibly an artifact from @MylesBorins's ad-hoc linkage last night. Probably not a big deal but certainly unnecessary.

eg: https://nodejs.org/download/release/latest-dubnium/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/

[MylesBorins]

Cyclical symlink should be gone now 😇

…

On Wed, Oct 31, 2018, 3:25 PM Kyle Smith ***@***.*** wrote: also, heads up @rvagg <https://github.com/rvagg>: looks like there's a cyclical symlink to v10.13.0 in the /download/release/latest-dubnium dir that we may want to prune --possibly an artifact from @MylesBorins <https://github.com/MylesBorins>'s ad-hoc linkage last night. Probably not a big deal but certainly unnecessary. eg: https://nodejs.org/download/release/latest-dubnium/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/v10.13.0/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV3LNv4CWrhcWRy8D4knDRmNZ5Qpsks5uqfklgaJpZM4YCo63> .