Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Differentiate markdown styles #121

Closed
a0viedo opened this issue Sep 9, 2015 · 12 comments · May be fixed by NOUIY/nodejs.org#59 or RahmaNiftaliyev/nodejs.org#46
Closed

docs: Differentiate markdown styles #121

a0viedo opened this issue Sep 9, 2015 · 12 comments · May be fixed by NOUIY/nodejs.org#59 or RahmaNiftaliyev/nodejs.org#46

Comments

@a0viedo
Copy link
Member

a0viedo commented Sep 9, 2015

First of all, I want to thank for all the hard work the team has been doing. Keep up with the great stuff!

Currently, for the markdown syntax changes the font is changing but it is almost unnoticeable. Example:
img

Adding a simple background color (like GitHub does) would be super helpful.

@fhemberger
Copy link
Contributor

Wow, this looks weird, what Browser/OS are you using?

@fhemberger fhemberger changed the title Differentiate markdown styles docs: Differentiate markdown styles Sep 10, 2015
@a0viedo
Copy link
Member Author

a0viedo commented Sep 10, 2015

@fhemberger I'm using Chrome v45.0.2454.85 under Windows 7.

@phillipj
Copy link
Member

Although it doesnt look quite as unnoticeable for me, I agree we could make inline code blocks stand out a bit more. Some cut-n-paste from github's styling:

BEFORE

image

AFTER

image

@fhemberger
Copy link
Contributor

@phillipj The screenshot was part of the docs, not the main website. ;)

@phillipj
Copy link
Member

@phillipj The screenshot was part of the docs, not the main website. ;)

Wooopsie, my bad! But that doesnt mean we cant improve it on the main site
though 😃

@fhemberger
Copy link
Contributor

I knew you were going to say that. ;) Sure thing, go ahead!

@phillipj
Copy link
Member

@fhemberger I could fix this in the docs, but I dont know where the source of those are located?

@fhemberger
Copy link
Contributor

Should be in https://github.com/nodejs/docs I guess. I lost a bit track of what's "the old stuff" vs. "the new stuff". 😄

@phillipj
Copy link
Member

That repo is more or less empty.. Maybe someone in @nodejs/documentation has some advice about the location of https://nodejs.org/api/ source files?

@phillipj
Copy link
Member

No luck on that team either 😞 Falling back to @rvagg then, which project is deployed to https://nodejs.org/api/?

@phillipj
Copy link
Member

PR fixing this just landed nodejs/node#3573, thanks for raising this issue 👍

@a0viedo
Copy link
Member Author

a0viedo commented Oct 30, 2015

@phillipj thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants