Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No LTS shown on main page #298

Closed
rvagg opened this issue Oct 29, 2015 · 9 comments
Closed

No LTS shown on main page #298

rvagg opened this issue Oct 29, 2015 · 9 comments

Comments

@rvagg
Copy link
Member

rvagg commented Oct 29, 2015

Re #261 /cc @phillipj

screen shot 2015-10-30 at 8 15 50 am

This is pretty urgent, would someone mind figuring out how to make v4.2.1 show as LTS?
@mikeal mikeal mentioned this issue Oct 29, 2015
Closed
@mikeal
Copy link
Contributor

mikeal commented Oct 29, 2015

@rvagg looking through the code it checks if the version definition has {lts: true} which I believe comes from the build system.

@phillipj
Copy link
Member

I'm on it

@rvagg
Copy link
Member Author

rvagg commented Oct 29, 2015

thanks @phillipj, just push straight to master when you have something (IMO)

@mikeal
Copy link
Contributor

mikeal commented Oct 29, 2015

nm, looks like the version def has {lts:false} so it's in the helper.

@phillipj
Copy link
Member

Sorry about that, a unit test will follow shortly ;)

@mikeal
Copy link
Contributor

mikeal commented Oct 29, 2015

looks like it got hot fixed :)

@rvagg
Copy link
Member Author

rvagg commented Oct 29, 2015

good work @phillipj, looks great!

@jasnell
Copy link
Member

jasnell commented Oct 29, 2015

+1

@stevemao
Copy link
Contributor

LOL that was quick!!! I was wondering why and 10 mins later this was fixed :)

@adamlaska adamlaska mentioned this issue Nov 26, 2023
Open
@ryan-ally ryan-ally mentioned this issue Nov 27, 2023
Open
@adamlaska adamlaska mentioned this issue Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mikeal @jasnell @rvagg @phillipj @stevemao