doc: fix nits in blog/release/v8.0.0.md #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
May 30, 2017
| @@ -200,12 +200,12 @@ AssertionError [ERR_ASSERTION]: false == true | |||
|
|
|||
| Information for static error codes can be queried quickly by referencing the | |||
| Node.js documentation. For instance, the URL to lookup information about the | |||
| `ERR_ASSERTION` error code is | |||
| https://nodejs.org/dist/latest-v7.x/docs/api/errors.html#ERR_ASSERTION. | |||
| `ERR_ARG_NOT_ITERABLE` error code is | |||
There was a problem hiding this comment.
I could have sworn that ERR_ASSERTION had been added... will have to make sure it is.
The link format does work tho... try
https://nodejs.org/dist/latest-v8.x/docs/api/errors.html#ERR_ARG_NOT_ITERABLE
lpinca
approved these changes
May 31, 2017
|
Should this wait 48 hours? |
|
That rule does not apply to the website but let's wait a little more to give other collaborators a chance to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not sure about this.