Skip to content

Conversation

@yous
Copy link
Contributor

@yous yous commented Jul 3, 2019

Fix #2251.

@nodejs/nodejs-ko: Review please.

Copy link
Contributor

@alexandrtovmach alexandrtovmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove all commented text, because it's unusable. Thanks

@yous
Copy link
Contributor Author

yous commented Jul 3, 2019

@alexandrtovmach Comments are for translators. We can't track all changes under locale/en, so we diff the comments of locale/ko and locale/en. Then it's way easier to know what's out-of-date, and update translations.

@alexandrtovmach
Copy link
Contributor

I see, okay let's merge it. Hope to make translation process easier soon.

@alexandrtovmach alexandrtovmach merged commit 2bf7de7 into nodejs:master Jul 3, 2019
@yous yous deleted the ko-get-involved-index branch July 3, 2019 09:44
@yous
Copy link
Contributor Author

yous commented Jul 3, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 error with "Edit on Github" link on https://nodejs.org/ko/get-involved/

3 participants