Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide: "Easy profiling for Node.js" #254

Merged
merged 1 commit into from
Oct 20, 2015
Merged

Add guide: "Easy profiling for Node.js" #254

merged 1 commit into from
Oct 20, 2015

Conversation

matthewloring
Copy link
Contributor

Adding a guide on the use of the tick processor and the built in Node.js
profiler to understand application performance.

@matthewloring
Copy link
Contributor Author

Submitting this here on the recommendation of nodejs/docs#45

cc @Qard

@Qard
Copy link
Member

Qard commented Oct 18, 2015

LGTM. 👍

@narqo
Copy link

narqo commented Oct 19, 2015

It'd be very handy. 👍

@evanlucas
Copy link
Contributor

This looks awesome. LGTM

});
```

Please note that these are NOT recommended handlers for authenticating users in your Node.js applications and are used purely for illustration purposes. You should not be trying to design your own cryptographic authentication mechanisms in general. It is much better to use existing, proven authentication solutions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Italic this sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Adding a guide on the use of the tick processor and the built in Node.js
profiler to understand application performance.
@stevemao
Copy link
Contributor

@nodejs/website @nodejs/benchmarking

@phillipj
Copy link
Member

LGTM

fhemberger added a commit that referenced this pull request Oct 20, 2015
Add guide: "Easy profiling for Node.js"
@fhemberger fhemberger merged commit 886bc35 into nodejs:master Oct 20, 2015
@fhemberger
Copy link
Contributor

Merged, although it's not linked on the site yet.

@matthewloring
Copy link
Contributor Author

Thanks! What is the process for getting this linked from the website?

@fhemberger
Copy link
Contributor

@matthewloring Add a link to the website. ;)

@bnb
Copy link
Contributor

bnb commented Oct 20, 2015

@fhemberger Where would the link be added? I can probably handle it if nobody else has the time/desire.

@fhemberger
Copy link
Contributor

@bnb Oh, that would be great! Create a new page "Guides" under "Docs" and add the link there.

Thanks!

@Qard
Copy link
Member

Qard commented Oct 20, 2015

The plan is to have a directory page for guides, topics and reference pages. I just haven't got around to making it yet. A static page would probably be fine for now too, if you want to push that through.

@bnb bnb self-assigned this Oct 21, 2015
@matthewloring
Copy link
Contributor Author

@bnb Were you able to look into including this in the website? I am happy to look into it but don't have any experience with the website code base yet.

@bnb
Copy link
Contributor

bnb commented Oct 31, 2015

@matthewloring Sorry, I've had a lot on my plate the last couple weeks (family member had heart surgery). I can try to do this now.

@bnb
Copy link
Contributor

bnb commented Oct 31, 2015

@fhemberger When you say create a new page "Guide" under "Docs", what exactly do you mean? Sorry for being thick.

@fhemberger
Copy link
Contributor

@bnb Add the page to the navigation structure in site.json and to /layouts/docs.hbs.

@bnb
Copy link
Contributor

bnb commented Oct 31, 2015

@fhemberger Thank you! 💯

@bnb bnb mentioned this pull request Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants