Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id, zh-CN: update translations and fix links #5312

Merged
merged 1 commit into from
Apr 27, 2023
Merged

id, zh-CN: update translations and fix links #5312

merged 1 commit into from
Apr 27, 2023

Conversation

nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 20, 2023 •
edited by SEWeiTung
Loading

  1. Add new translations for the Simplified Chinese.
  2. Fix error links for the hidden strings in the Simplified Chinese.
  3. Update translations for Indonesian.

@nodejs-github-bot nodejs-github-bot requested a review from a team as a code owner April 20, 2023 17:31
@nodejs-github-bot nodejs-github-bot added crowdin i18n Issues/PRs related to the Website Internationalisation labels Apr 20, 2023
@vercel
Copy link

vercel bot commented Apr 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nodejs-org ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2023 0:44am
nodejs-org-stories ⬜️ Ignored (Inspect) Apr 22, 2023 0:44am

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 20, 2023 17:32 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 20, 2023 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 20, 2023 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 01:01 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 01:17 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 01:19 Inactive
SEWeiTung
SEWeiTung approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@SEWeiTung SEWeiTung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the files are forcely changed to the right formation manually, and I don't know why it always happens when in Crowdin. And luckily, someone who has allowed us to directly edit the translations for the generated files of Crowdin.

What I did is just to copy the file from Crowdin's, and run 'lint:md -- --fix" one by one to fix each of these errors. And I also did a quick merge and forcely pushed to the PR to prettier it.

Here's an approval for the Simplified Chinese.

Mr7Gabriel
Mr7Gabriel approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Mr7Gabriel Mr7Gabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK all looks good, Thanks @MaledongGit for fixing the foramtions error by crowdin

@SEWeiTung SEWeiTung changed the title chore(i18n): crowdin sync id,zh-CN: update translations and fix links Apr 21, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 10:12 Inactive
@SEWeiTung SEWeiTung changed the title id,zh-CN: update translations and fix links zh-CN: update translations and fix links Apr 21, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 10:22 Inactive
@SEWeiTung
Copy link
Contributor

SEWeiTung commented Apr 21, 2023 •
edited
Loading

@Mr7Gabriel : From the merged files, it seems Crowdin just broke the formation of Indonesian files without any changes to it. So there're only the Simplified Chinese files left now. Please check it and confirm.

@Mr7Gabriel
Copy link
Contributor

@MaledongGit Ahhh, I just got the information now because the email notification from Crowdin was buried among other email messages,
Now the translation for Indonesian has been completed, but Perhaps it will be synced from Crowdin to here in around 3 hours or tomorrow, unless someone performs a sudden sync from Crowdin.

@SEWeiTung SEWeiTung changed the title zh-CN: update translations and fix links id, zh-CN: update translations and fix links Apr 22, 2023
@nodejs-github-bot @SEWeiTung
id, zh-CN: update translations and fix links
f08f673 
1. Add new translations for the Simplified Chinese.
2. Fix error links for the hidden strings in the Simplified Chinese.
3. Update translations for Indonesian.
@SEWeiTung
Copy link
Contributor

No problem, there're too many submits here, it seems everything goes fine and I did a rebase and re-force to submit them together.

SEWeiTung
SEWeiTung approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@SEWeiTung SEWeiTung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM in the Simplified Chinese

Mr7Gabriel
Mr7Gabriel approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@Mr7Gabriel Mr7Gabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Re-Check) id-ID translations, It seems that there's nothing that needs to be changed.

ovflowd
ovflowd approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@ovflowd ovflowd merged commit 80e0638 into main Apr 27, 2023
@ovflowd ovflowd deleted the chore/crowdin branch April 27, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr7Gabriel Mr7Gabriel Mr7Gabriel approved these changes

@SEWeiTung SEWeiTung SEWeiTung approved these changes

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @SEWeiTung @Mr7Gabriel @ovflowd