chore: Create a prebuild script to generate next data. #5461
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Merged this PR as it is simple enough and unblocks another PR. |
|
Just to double-check @Harkunwar you tested this command indeed gets invoked before build, right? |
|
@ovflowd Yes, I did check and it was working. I just also realized and So now it's executing twice since it's also part of the build script. Should we change the name of the script from |
|
I know that prebuild is a special keyword. Any script that starts with “pre” or “post” and as a suffix of another script name, will then either run before or after. My intent here was to check if the script is generating the files as expected 👀 |
|
I don’t get it why it would be executing twice. Where is it being invoked for the 2nd time? |
|
@ovflowd Yes, the files are being generated. It's being invoked twice because of this change. "build": "cross-env NODE_NO_WARNINGS=1 npm run prebuild && next build", |
Description
Currently we're generating next-data at the lint stage, which isn't the right place. This PR moves that generation to a
prebuildstage.Related Issues
Fixes #5455
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing, and/ornpx turbo test:snapshotto update snapshots if I created and/or updated React Components.