-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about spread operator limitations #661
Conversation
Should the language be explicit about node 6.x having greater support for the spear operator? |
Actually... in thinking about it more the only way this change makes sense will be if we update the information regarding the spread operator at the end of the month when we bump to 6, as 5 will no longer be receiving support |
Yeah, was thinking the same. I mean we can update it when node 6 will be released with something like: |
Or just wait for node 6 and use a sentence similar to the above one directly. |
You could send this PR directly to 5.x and send the other to master. |
Whoever reads site contents, reads master afaik. |
the generated docs for v5 will be made from that branch's doc folder though |
@thealphanerd Are you suggesting to move this pr to node repo? Otherwise I don't get it. |
@lpinca OH darn... this is what I get for responding via email when I am not fully awake yet. I thought this was against the node repo. Sorry for the confusion |
No problem :) |
I've updated the pr, but it's probably better to close it. |
Ok, closing this now. Feel free to reopen this PR if required. |
This improves the existing note about the spread operator specifying that it only works with array literals and function calls on Node 5.x.
Closes #653.