From cc33ee8dfd800c5d45cd112a5944b1970709e517 Mon Sep 17 00:00:00 2001 From: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com> Date: Sun, 2 Jun 2024 06:12:20 -0500 Subject: [PATCH 1/2] Update CONTRIBUTING.md Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f0bb5688f8395..e6e8b2814319c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -128,7 +128,7 @@ for getting things done and landing your contribution. > We use [GitHub Merge Queues](https://github.blog/2023-07-12-github-merge-queue-is-generally-available/) > which means that before merge the PRs get automatically updated and checked against the latest changes on the base branch. > -> This also reduces the amount of times we need to run our CI checks, as every new push requires freshly new CI-checks. +> This also reduces the amount of times we need to run our CI checks, as every new push requires fresh new CI-checks. ### CLI Commands From 6fd749239a0a0b1fbbfa30ad1369f7d32ada3aa0 Mon Sep 17 00:00:00 2001 From: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com> Date: Sun, 2 Jun 2024 06:15:40 -0500 Subject: [PATCH 2/2] Update getNodeDownloadSnippet.ts updated download instructions to notify users on unix systems that restarting the terminal may be necessary to continue to step 2 after first installing nvm Signed-off-by: NotYourAverageGamer <104248676+NotYourAverageGamer@users.noreply.github.com> --- util/getNodeDownloadSnippet.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/getNodeDownloadSnippet.ts b/util/getNodeDownloadSnippet.ts index e4a7cfc15e6d5..f2568094e12bc 100644 --- a/util/getNodeDownloadSnippet.ts +++ b/util/getNodeDownloadSnippet.ts @@ -36,7 +36,7 @@ export const getNodeDownloadSnippet = (release: NodeRelease, os: UserOS) => { # installs nvm (Node Version Manager) curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash - # download and install Node.js + # download and install Node.js (you may need to restart the terminal) nvm install ${release.major} # verifies the right Node.js version is in the environment