asynchronously loading the webfont + caching it #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }); | ||
| xhr.open('get', '/static/fonts/webfont.css'); | ||
| xhr.send(); |
There was a problem hiding this comment.
btw.: yes, we load the webfonts.css every time, and also update the cache every time. The user still gets a fast experience, the webfonts.css will be cached, but in case of new and different fonts, we still get an update.
This was referenced Sep 2, 2015
|
Guess this is kind of obsolete now with aa4b373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #57:
webfont.csscontains "Source Sans Pro" in weights 300, 400, 600 and 700. I removed the italic styles, mainly because they aren't used anywhere on the site.footer.hbscontains a JavaScript, ajax-ingwebfont.cssand putting the contents into localStorage.html-head.hbsloads CSS from localStorage and puts it as the first styles, practically inlining the webfonts.prism-tomorrow.cssand putting it at the end oflayouts/about.hbs-- this might be not valid, but browsers behave friendly: They load it as the last resource, non-blocking.