-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: upgrade to node v22 #7282
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
cc @nodejs/nodejs-website requesting fast track here :) |
-1 for fast track. a fast tack is for modifications that have to be land now if not it degrades the UX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Apologies for the language, I'm just unsatisfied with these random rules you're coming up out from nowhere. I wouldn't have requested fast-track if this does not apply to a fast-track. You can still be against the fast-track, but do not use wording that makes it sound that you're basing your decision on the CONTRIBUTING guidelines. |
yeah i think fast-track can certainly be warranted if we are in a position where our prod deployments in vercel are on a different version than we build and test - that could lead to unexpected behavior. so minimizing the amount of time we are in that position is prudent |
My understanding is that fast-tracking is not a matter of urgency, but a matter of complexity. |
you are right - urgency is covered earlier in https://github.com/nodejs/nodejs.org/blob/main/CONTRIBUTING.md#before-merging |
This PR upgrades all references of Node.js v20 to v22 (Vercel already got updated to v22)