Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: upgrade to node v22 #7282

Merged
merged 1 commit into from
Nov 25, 2024
Merged

meta: upgrade to node v22 #7282

merged 1 commit into from
Nov 25, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 25, 2024

This PR upgrades all references of Node.js v20 to v22 (Vercel already got updated to v22)

@ovflowd ovflowd requested a review from a team as a code owner November 25, 2024 10:58
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 25, 2024 11:00am

Copy link

github-actions bot commented Nov 25, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

github-actions bot commented Nov 25, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.227s ⏱️

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Nov 25, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Nov 25, 2024

cc @nodejs/nodejs-website requesting fast track here :)

@AugustinMauroy AugustinMauroy mentioned this pull request Nov 25, 2024
4 tasks
@AugustinMauroy
Copy link
Member

-1 for fast track. a fast tack is for modifications that have to be land now if not it degrades the UX

.nvmrc Show resolved Hide resolved
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ovflowd
Copy link
Member Author

ovflowd commented Nov 25, 2024

-1 for fast track. a fast tack is for modifications that have to be land now if not it degrades the UX

What sort of bullshit is this, where is this written?

Apologies for the language, I'm just unsatisfied with these random rules you're coming up out from nowhere. I wouldn't have requested fast-track if this does not apply to a fast-track.

You can still be against the fast-track, but do not use wording that makes it sound that you're basing your decision on the CONTRIBUTING guidelines.

@ovflowd
Copy link
Member Author

ovflowd commented Nov 25, 2024

image

apps/site/package.json Show resolved Hide resolved
apps/site/package.json Show resolved Hide resolved
@bmuenzenmeyer
Copy link
Collaborator

yeah i think fast-track can certainly be warranted if we are in a position where our prod deployments in vercel are on a different version than we build and test - that could lead to unexpected behavior. so minimizing the amount of time we are in that position is prudent

@ovflowd
Copy link
Member Author

ovflowd commented Nov 25, 2024

yeah i think fast-track can certainly be warranted if we are in a position where our prod deployments in vercel are on a different version than we build and test - that could lead to unexpected behavior. so minimizing the amount of time we are in that position is prudent

My understanding is that fast-tracking is not a matter of urgency, but a matter of complexity.

@bmuenzenmeyer
Copy link
Collaborator

you are right - urgency is covered earlier in https://github.com/nodejs/nodejs.org/blob/main/CONTRIBUTING.md#before-merging

@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Nov 25, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 25, 2024
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit fbd443d Nov 25, 2024
28 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the chore/node-v22 branch November 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants