Move certain fs/utils to c++

[anonrig]

All filesystem operations has the following functions, that could improve the performance if moved to C++:

• getValidatedPath
• getValidMode
• path.toNamespacedPath

[tony-go]

Interesting one :)

[H4ad]

toNamespacedPath already has a C++ port: https://github.com/nodejs/node/blob/main/src/node_file.cc#L844-L855

For this one, we just need to expose.

[anonrig]

@H4ad we need to call C++ function from all functions in node_file.cc and remove the call from javascript side (lib/fs.js).

[tony-go]

For getValidatedPath, it seems that pathModule.toNamespacedPath is often called after it, maybe we should move both?

[andremralves]

path.toNamespacedPath makes a call to another function win32.resolve(), is there an equivalent of this function in the c++ land or should we move it too?

[anonrig]

path.toNamespacedPath makes a call to another function win32.resolve(), is there an equivalent of this function in the c++ land or should we move it too?

I don't think so

[Uzlopak]

Just want to say, that by moving validators to c++ could mean that the Errors could contain them in the stacktrace. Thats why we have currently hideStackframes functions, because there is no inline specifier in javascript. Maybe you also have to inline the validators in c++, to avoid the stacktraces to not contain the validators.

[RafaelGSS]

path.toNamespacedPath makes a call to another function win32.resolve(), is there an equivalent of this function in the c++ land or should we move it too?

Actually, I and @Ceres6 are working on that. We're porting path.resolve() to the C++ side to use in the permission model.