From 7268f7f47f541fd417e21419250ded328815f81d Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 17:50:31 -0700 Subject: [PATCH 1/7] quic: test client connect invalid minDHSize --- test/parallel/test-quic-client-connect-err.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 test/parallel/test-quic-client-connect-err.js diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js new file mode 100644 index 0000000000..089d11c631 --- /dev/null +++ b/test/parallel/test-quic-client-connect-err.js @@ -0,0 +1,19 @@ +'use strict'; + +// Tests QuicClientSession constructor options errors + +const common = require('../common'); +if (!common.hasQuic) + common.skip('missing quic'); + +const assert = require('assert'); +const { createSocket } = require('quic'); + +const client = createSocket(); + +// Test invalid minDHSize options argument +['test', 1n, {}, [], false].forEach((minDHSize) => { + assert.throws(() => client.connect({ minDHSize }), { + code: 'ERR_INVALID_ARG_TYPE' + }); +}); From f220a3e33a6b8085bca059e0fdc64339c68b0380 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 17:54:10 -0700 Subject: [PATCH 2/7] quic: test client connect invalid port --- test/parallel/test-quic-client-connect-err.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js index 089d11c631..65935b11a4 100644 --- a/test/parallel/test-quic-client-connect-err.js +++ b/test/parallel/test-quic-client-connect-err.js @@ -17,3 +17,10 @@ const client = createSocket(); code: 'ERR_INVALID_ARG_TYPE' }); }); + +// Test invalid QuicSocket port argument option +[-1, 'test', 1n, {}, [], NaN, false].forEach((port) => { + assert.throws(() => client.connect({ port }), { + code: 'ERR_INVALID_ARG_VALUE' + }); +}); From 1c9813a638bf57b22e2239d87ad0e27fb9efc678 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 18:01:50 -0700 Subject: [PATCH 3/7] quic: test client connect invalid address --- test/parallel/test-quic-client-connect-err.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js index 65935b11a4..9d369b5f74 100644 --- a/test/parallel/test-quic-client-connect-err.js +++ b/test/parallel/test-quic-client-connect-err.js @@ -18,9 +18,16 @@ const client = createSocket(); }); }); -// Test invalid QuicSocket port argument option +// Test invalid port argument option [-1, 'test', 1n, {}, [], NaN, false].forEach((port) => { assert.throws(() => client.connect({ port }), { code: 'ERR_INVALID_ARG_VALUE' }); }); + +// Test invalid addressargument option +[-1, 10, 1n, {}, []].forEach((address) => { + assert.throws(() => client.connect({ address }), { + code: 'ERR_INVALID_ARG_TYPE' + }); +}); From 28ab7fe6f0a0b15700eb36edbdc5d6349b92c444 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 18:14:43 -0700 Subject: [PATCH 4/7] quic: test client connect IP address --- test/parallel/test-quic-client-connect-err.js | 26 ++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js index 9d369b5f74..1d5d5e9736 100644 --- a/test/parallel/test-quic-client-connect-err.js +++ b/test/parallel/test-quic-client-connect-err.js @@ -25,9 +25,33 @@ const client = createSocket(); }); }); -// Test invalid addressargument option +// Test invalid address argument option [-1, 10, 1n, {}, []].forEach((address) => { assert.throws(() => client.connect({ address }), { code: 'ERR_INVALID_ARG_TYPE' }); }); + +// Test address can't be IP address argument option +[ + '0.0.0.0', + '8.8.8.8', + '127.0.0.1', + '192.168.0.1', + '::', + '1::', + '::1', + '1::8', + '1::7:8', + '1:2:3:4:5:6:7:8', + '1:2:3:4:5:6::8', + '2001:0000:1234:0000:0000:C1C0:ABCD:0876', + '3ffe:0b00:0000:0000:0001:0000:0000:000a', + 'a:0:0:0:0:0:0:0', + 'fe80::7:8%eth0', + 'fe80::7:8%1' +].forEach((address) => { + assert.throws(() => client.connect({ address }), { + code: 'ERR_INVALID_ARG_VALUE' + }); +}); From 72109791b65487494b833a9db483affdecde0671 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 18:19:45 -0700 Subject: [PATCH 5/7] quic: test client connect remoteTransportParams --- test/parallel/test-quic-client-connect-err.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js index 1d5d5e9736..74a5222728 100644 --- a/test/parallel/test-quic-client-connect-err.js +++ b/test/parallel/test-quic-client-connect-err.js @@ -55,3 +55,10 @@ const client = createSocket(); code: 'ERR_INVALID_ARG_VALUE' }); }); + +// Test invalid remoteTransportParams argument option +[-1, 'test', 1n, {}, []].forEach((remoteTransportParams) => { + assert.throws(() => client.connect({ remoteTransportParams }), { + code: 'ERR_INVALID_ARG_TYPE' + }); +}); From a5cee9fe2315a51fc3904040739065c0892e8b3f Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 18:20:32 -0700 Subject: [PATCH 6/7] quic: test client connect sessionTicket --- test/parallel/test-quic-client-connect-err.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js index 74a5222728..dae0de76cc 100644 --- a/test/parallel/test-quic-client-connect-err.js +++ b/test/parallel/test-quic-client-connect-err.js @@ -62,3 +62,10 @@ const client = createSocket(); code: 'ERR_INVALID_ARG_TYPE' }); }); + +// Test invalid sessionTicket argument option +[-1, 'test', 1n, {}, []].forEach((sessionTicket) => { + assert.throws(() => client.connect({ sessionTicket }), { + code: 'ERR_INVALID_ARG_TYPE' + }); +}); From d225ef1ea7b9c52eff67946ca6d275b02bd843c1 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sat, 5 Oct 2019 18:21:32 -0700 Subject: [PATCH 7/7] quic: test client connect alpn --- test/parallel/test-quic-client-connect-err.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/parallel/test-quic-client-connect-err.js b/test/parallel/test-quic-client-connect-err.js index dae0de76cc..a4b1f6ae49 100644 --- a/test/parallel/test-quic-client-connect-err.js +++ b/test/parallel/test-quic-client-connect-err.js @@ -69,3 +69,10 @@ const client = createSocket(); code: 'ERR_INVALID_ARG_TYPE' }); }); + +// Test invalid alpn argument option +[-1, 10, 1n, {}, []].forEach((alpn) => { + assert.throws(() => client.connect({ alpn }), { + code: 'ERR_INVALID_ARG_TYPE' + }); +});