websocket: use FixedQueue instead of Set

[tsctx]

@KhafraDev

[mcollina]

lgtm

[ronag]

Why not fixed_queue from node core?

[tsctx]

Why not fixed_queue from node core?

There is no particular reason for this.

[tsctx]

In this use case, I prefer the simple linkedlist; Initialization of the array of 2048 entries takes time :)

[ronag]

In this use case, I prefer the simple linkedlist; Initialization of the array of 2048 entries takes time :)

I think that is amortized quite quickly...

[KhafraDev]

do you have benchmarks?

[tsctx]

do you have benchmarks?

What about?

[tsctx]

If it was about sending data, it would be 1.2 times faster since we changed to zero-copy.

[KhafraDev]

Yeah, sending messages. Do you have the data to backup the 1.2x faster claim?

[tsctx]

okey, look this

https://github.com/nodejs/undici/blob/370f8cbf20ccf80dc3dbc0a3c6d39a041b1eb631/benchmarks/websocket/websocket-send-buffer.mjs

benchmark      time (avg)             (min … max)       p75       p99      p999
------------------------------------------------- -----------------------------
• send
------------------------------------------------- -----------------------------
undici      1'658 µs/iter   (1'305 µs … 4'145 µs)  1'673 µs  3'043 µs  4'145 µs <- before
undici      1'467 µs/iter   (1'187 µs … 6'165 µs)  1'442 µs  4'022 µs  6'165 µs <- after

[tsctx]

In this use case, I prefer the simple linkedlist; Initialization of the array of 2048 entries takes time :)

I think that is amortized quite quickly...

Rewrite with fixed_queue!

[KhafraDev]

why is queue being lazily created?

[KhafraDev]

tests are failing

[tsctx]

I don't have time right now, so I will rewrite it in another PR.