feat!: Allow project to be installable #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
commented
Jun 15, 2023
|
I'm definitely no expert in this stuff, so happy to take any feedback. |
cjihrig
approved these changes
Jun 15, 2023
phated
force-pushed
the
phated/installable-library
branch
from
bd440d9
to
feddcbf
Compare
3 tasks
mhdawson
pushed a commit
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the cmake build of the project to add install targets for uvwasi. This will make it possible for pkg-config or cmake build pipelines to discover globally installed uvwasi.
To install uvwasi, you'd run
cmake --install outafter you build.I also removed the
WITH_SYSTEM_LIBUVoption because we should be using the globally installed libuv if it can be found. If people are very against this change, I can introduce a flag to disable this behavior.I've tested this against a local branch of wasm-micro-runtime and it seems to be working. My plan is to add that build to CI once they accept my changes.
Closes #199