fix: temporarily removes the prePublish step allowing us to publish a new version and for users to use this module. #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new version and for users to use this module. The Context: When the release PR is merged, this includes changes to the package-lock.json file which in turn results in a modification of the SBOM, which means that when the release is published, the SBOM is out of date. A tangible example: clone this repository: https://github.com/nodeshift/faas-js-runtime change into the repo directory and run git checkout v2.2.1 (the most recent release tag) run npm run sbom which generates an SBOM based on the current package-lock.json file run git diff to see what should have been included in the release SBOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lance i "borrowed" this from your release-please issue :)
The Context:
When the release PR is merged, this includes changes to the package-lock.json file which in turn results in a modification of the SBOM, which means that when the release is published, the SBOM is out of date.
A tangible example:
clone this repository: https://github.com/nodeshift/faas-js-runtime change into the repo directory and run git checkout v2.2.1 (the most recent release tag) run npm run sbom which generates an SBOM based on the current package-lock.json file run git diff to see what should have been included in the release SBOM