From 7006a83662986ad7b406bf882210b52ee5e5f20f Mon Sep 17 00:00:00 2001 From: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Tue, 26 Sep 2023 13:03:30 +0100 Subject: [PATCH] chore: delete unnecessary nix files (#2840) --- acvm-repo/.envrc | 20 ---- acvm-repo/.gitignore | 1 - acvm-repo/flake.lock | 132 ------------------------- acvm-repo/flake.nix | 231 ------------------------------------------- 4 files changed, 384 deletions(-) delete mode 100644 acvm-repo/.envrc delete mode 100644 acvm-repo/flake.lock delete mode 100644 acvm-repo/flake.nix diff --git a/acvm-repo/.envrc b/acvm-repo/.envrc deleted file mode 100644 index 494e7adf16c..00000000000 --- a/acvm-repo/.envrc +++ /dev/null @@ -1,20 +0,0 @@ -# Based on https://github.com/direnv/direnv-vscode/blob/158e8302c2594cc0eaa5f8b4f0cafedd4e1c0315/.envrc - -# You can define your system-specific logic (like Git settings or GH tokens) in .envrc.local -# If that logic is usable by other people and might improve development environment, consider -# contributing it to this file! - -source_env_if_exists .envrc.local - -if [[ -z "${SKIP_NIX:-}" ]] && has nix; then - - if nix flake metadata &>/dev/null && has use_flake; then - # use flakes if possible - use flake - - else - # Otherwise fall back to pure nix - use nix - fi - -fi \ No newline at end of file diff --git a/acvm-repo/.gitignore b/acvm-repo/.gitignore index 54178440f50..e6cd42a8496 100644 --- a/acvm-repo/.gitignore +++ b/acvm-repo/.gitignore @@ -4,4 +4,3 @@ # Cargo.lock result outputs/ -.direnv \ No newline at end of file diff --git a/acvm-repo/flake.lock b/acvm-repo/flake.lock deleted file mode 100644 index 84fbe2e9edf..00000000000 --- a/acvm-repo/flake.lock +++ /dev/null @@ -1,132 +0,0 @@ -{ - "nodes": { - "crane": { - "inputs": { - "flake-compat": [ - "flake-compat" - ], - "flake-utils": [ - "flake-utils" - ], - "nixpkgs": [ - "nixpkgs" - ], - "rust-overlay": [ - "rust-overlay" - ] - }, - "locked": { - "lastModified": 1688772518, - "narHash": "sha256-ol7gZxwvgLnxNSZwFTDJJ49xVY5teaSvF7lzlo3YQfM=", - "owner": "ipetkov", - "repo": "crane", - "rev": "8b08e96c9af8c6e3a2b69af5a7fa168750fcf88e", - "type": "github" - }, - "original": { - "owner": "ipetkov", - "repo": "crane", - "type": "github" - } - }, - "flake-compat": { - "flake": false, - "locked": { - "lastModified": 1673956053, - "narHash": "sha256-4gtG9iQuiKITOjNQQeQIpoIB6b16fm+504Ch3sNKLd8=", - "owner": "edolstra", - "repo": "flake-compat", - "rev": "35bb57c0c8d8b62bbfd284272c928ceb64ddbde9", - "type": "github" - }, - "original": { - "owner": "edolstra", - "repo": "flake-compat", - "type": "github" - } - }, - "flake-utils": { - "inputs": { - "systems": "systems" - }, - "locked": { - "lastModified": 1689068808, - "narHash": "sha256-6ixXo3wt24N/melDWjq70UuHQLxGV8jZvooRanIHXw0=", - "owner": "numtide", - "repo": "flake-utils", - "rev": "919d646de7be200f3bf08cb76ae1f09402b6f9b4", - "type": "github" - }, - "original": { - "owner": "numtide", - "repo": "flake-utils", - "type": "github" - } - }, - "nixpkgs": { - "locked": { - "lastModified": 1688392541, - "narHash": "sha256-lHrKvEkCPTUO+7tPfjIcb7Trk6k31rz18vkyqmkeJfY=", - "owner": "NixOS", - "repo": "nixpkgs", - "rev": "ea4c80b39be4c09702b0cb3b42eab59e2ba4f24b", - "type": "github" - }, - "original": { - "owner": "NixOS", - "ref": "nixos-22.11", - "repo": "nixpkgs", - "type": "github" - } - }, - "root": { - "inputs": { - "crane": "crane", - "flake-compat": "flake-compat", - "flake-utils": "flake-utils", - "nixpkgs": "nixpkgs", - "rust-overlay": "rust-overlay" - } - }, - "rust-overlay": { - "inputs": { - "flake-utils": [ - "flake-utils" - ], - "nixpkgs": [ - "nixpkgs" - ] - }, - "locked": { - "lastModified": 1690338181, - "narHash": "sha256-Sz2oQ9aNS3MVncnCMndr0302G26UrFUfPynoH2iLjsg=", - "owner": "oxalica", - "repo": "rust-overlay", - "rev": "b7f0b7b58b3c6f14a1377ec31a3d78b23ab843ec", - "type": "github" - }, - "original": { - "owner": "oxalica", - "repo": "rust-overlay", - "type": "github" - } - }, - "systems": { - "locked": { - "lastModified": 1681028828, - "narHash": "sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768=", - "owner": "nix-systems", - "repo": "default", - "rev": "da67096a3b9bf56a91d16901293e51ba5b49a27e", - "type": "github" - }, - "original": { - "owner": "nix-systems", - "repo": "default", - "type": "github" - } - } - }, - "root": "root", - "version": 7 -} diff --git a/acvm-repo/flake.nix b/acvm-repo/flake.nix deleted file mode 100644 index 0491d855a43..00000000000 --- a/acvm-repo/flake.nix +++ /dev/null @@ -1,231 +0,0 @@ -{ - description = "Javascript bindings for the ACVM"; - - inputs = { - nixpkgs = { - url = "github:NixOS/nixpkgs/nixos-22.11"; - }; - - flake-utils = { - url = "github:numtide/flake-utils"; - }; - - flake-compat = { - url = "github:edolstra/flake-compat"; - flake = false; - }; - - rust-overlay = { - url = "github:oxalica/rust-overlay"; - # All of these inputs (a.k.a. dependencies) need to align with inputs we - # use so they use the `inputs.*.follows` syntax to reference our inputs - inputs = { - nixpkgs.follows = "nixpkgs"; - flake-utils.follows = "flake-utils"; - }; - }; - - crane = { - url = "github:ipetkov/crane"; - # All of these inputs (a.k.a. dependencies) need to align with inputs we - # use so they use the `inputs.*.follows` syntax to reference our inputs - inputs = { - nixpkgs.follows = "nixpkgs"; - flake-utils.follows = "flake-utils"; - flake-compat.follows = "flake-compat"; - rust-overlay.follows = "rust-overlay"; - }; - }; - }; - - outputs = - { self, nixpkgs, crane, flake-utils, rust-overlay, ... }: #, barretenberg - flake-utils.lib.eachDefaultSystem (system: - let - pkgs = import nixpkgs { - inherit system; - overlays = [ - rust-overlay.overlays.default - ]; - }; - - rustToolchain = pkgs.rust-bin.stable."1.66.0".default.override { - # We include rust-src to ensure rust-analyzer works. - # See https://discourse.nixos.org/t/rust-src-not-found-and-other-misadventures-of-developing-rust-on-nixos/11570/4 - extensions = [ "rust-src" ]; - targets = [ "wasm32-unknown-unknown" ] - ++ pkgs.lib.optional (pkgs.hostPlatform.isx86_64 && pkgs.hostPlatform.isLinux) "x86_64-unknown-linux-gnu" - ++ pkgs.lib.optional (pkgs.hostPlatform.isAarch64 && pkgs.hostPlatform.isLinux) "aarch64-unknown-linux-gnu" - ++ pkgs.lib.optional (pkgs.hostPlatform.isx86_64 && pkgs.hostPlatform.isDarwin) "x86_64-apple-darwin" - ++ pkgs.lib.optional (pkgs.hostPlatform.isAarch64 && pkgs.hostPlatform.isDarwin) "aarch64-apple-darwin"; - }; - - craneLib = (crane.mkLib pkgs).overrideToolchain rustToolchain; - - crateACVMJSDefinitions = craneLib.crateNameFromCargoToml { - cargoToml = ./acvm_js/Cargo.toml; - }; - - crateACVMDefinitions = craneLib.crateNameFromCargoToml { - cargoToml = ./acvm/Cargo.toml; - }; - - - sharedEnvironment = { - # Barretenberg fails if tests are run on multiple threads, so we set the test thread - # count to 1 throughout the entire project - # - # Note: Setting this allows for consistent behavior across build and shells, but is mostly - # hidden from the developer - i.e. when they see the command being run via `nix flake check` - # RUST_TEST_THREADS = "1"; - BARRETENBERG_ARCHIVE = builtins.fetchurl { - url = "https://github.com/AztecProtocol/barretenberg/releases/download/barretenberg-v0.4.5/acvm_backend.wasm.tar.gz"; - sha256 = "sha256:0z24yhvxc0dr13xj7y4xs9p42lzxwpazrmsrdpcgynfajkk6vqy4"; - }; - }; - - wasmEnvironment = sharedEnvironment // { }; - - sourceFilter = path: type: - (craneLib.filterCargoSources path type); - - # The `self.rev` property is only available when the working tree is not dirty - GIT_COMMIT = if (self ? rev) then self.rev else "unknown"; - GIT_DIRTY = if (self ? rev) then "false" else "true"; - - extraBuildInputs = pkgs.lib.optionals pkgs.stdenv.isDarwin [ - # Need libiconv and apple Security on Darwin. See https://github.com/ipetkov/crane/issues/156 - pkgs.libiconv - pkgs.darwin.apple_sdk.frameworks.Security - ]; - - commonArgs = { - inherit (crateACVMDefinitions) pname version; - src = pkgs.lib.cleanSourceWith { - src = craneLib.path { - path = ./.; - }; - filter = sourceFilter; - }; - - cargoClippyExtraArgs = "--package acvm_js --all-targets -- -D warnings"; - cargoTestExtraArgs = "--workspace"; - - # We don't want to run checks or tests when just building the project - doCheck = false; - }; - - # Combine the environment and other configuration needed for crane to build with the wasm feature - acvmjsWasmArgs = wasmEnvironment // commonArgs // { - - inherit (crateACVMJSDefinitions) pname version; - - cargoExtraArgs = "--package acvm_js --target=wasm32-unknown-unknown"; - - cargoVendorDir = craneLib.vendorCargoDeps { - src = ./.; - }; - - buildInputs = [ ] ++ extraBuildInputs; - - }; - - # Build *just* the cargo dependencies, so we can reuse all of that work between runs - cargo-artifacts = craneLib.buildDepsOnly commonArgs; - - wasm-bindgen-cli = pkgs.callPackage ./acvm_js/nix/wasm-bindgen-cli/default.nix { - rustPlatform = pkgs.makeRustPlatform { - rustc = rustToolchain; - cargo = rustToolchain; - }; - }; - - in - rec { - checks = { - - cargo-clippy = craneLib.cargoClippy (commonArgs // sharedEnvironment // { - inherit GIT_COMMIT GIT_DIRTY; - - cargoArtifacts = cargo-artifacts; - doCheck = true; - }); - - cargo-test = craneLib.cargoTest (commonArgs // sharedEnvironment // { - inherit GIT_COMMIT GIT_DIRTY; - - cargoArtifacts = cargo-artifacts; - doCheck = true; - }); - - cargo-fmt = craneLib.cargoFmt (commonArgs // sharedEnvironment // { - inherit GIT_COMMIT GIT_DIRTY; - - cargoArtifacts = cargo-artifacts; - doCheck = true; - }); - - }; - - packages = { - default = craneLib.mkCargoDerivation (acvmjsWasmArgs // rec { - - cargoArtifacts = cargo-artifacts; - - inherit GIT_COMMIT; - inherit GIT_DIRTY; - - COMMIT_SHORT = builtins.substring 0 7 GIT_COMMIT; - VERSION_APPENDIX = if GIT_DIRTY == "true" then "-dirty" else ""; - - src = ./.; #craneLib.cleanCargoSource (craneLib.path ./.); - - nativeBuildInputs = with pkgs; [ - binaryen - which - git - jq - rustToolchain - wasm-bindgen-cli - ]; - - CARGO_TARGET_DIR = "./target"; - - buildPhaseCargoCommand = '' - bash ./acvm_js/buildPhaseCargoCommand.sh - ''; - - installPhase = '' - bash ./acvm_js/installPhase.sh - ''; - - }); - inherit cargo-artifacts; - }; - - # Setup the environment to match the stdenv from `nix build` & `nix flake check`, and - # combine it with the environment settings, the inputs from our checks derivations, - # and extra tooling via `nativeBuildInputs` - devShells.default = pkgs.mkShell (wasmEnvironment // { - # inputsFrom = builtins.attrValues checks; - - nativeBuildInputs = with pkgs; [ - starship - nil - nixpkgs-fmt - which - git - jq - toml2json - rustToolchain - wasm-bindgen-cli - nodejs - yarn - ]; - - shellHook = '' - eval "$(starship init bash)" - ''; - }); - }); -}