From 60bbbdcaf03dd2fbeb3d5ab73ac1b590a902f4cb Mon Sep 17 00:00:00 2001 From: Maxim Vezenov Date: Fri, 16 Aug 2024 20:52:11 +0000 Subject: [PATCH 1/3] update header for brillig opcode report --- .github/workflows/gates_report_brillig.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/gates_report_brillig.yml b/.github/workflows/gates_report_brillig.yml index 05fe2f855e4..ae363af1689 100644 --- a/.github/workflows/gates_report_brillig.yml +++ b/.github/workflows/gates_report_brillig.yml @@ -77,6 +77,8 @@ jobs: uses: noir-lang/noir-gates-diff@93e4cae1229d669de61f0ac76d32e47cefe4adcc with: report: gates_report_brillig.json + header: | + # Changes to Brillig byte code sizes summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) - name: Add gates diff to sticky comment From d65b0661d28ed3ae2255c6a5817a047794a82efa Mon Sep 17 00:00:00 2001 From: Maxim Vezenov Date: Fri, 16 Aug 2024 20:55:06 +0000 Subject: [PATCH 2/3] use brillig_bytecode_diff for job id --- .github/workflows/gates_report_brillig.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/gates_report_brillig.yml b/.github/workflows/gates_report_brillig.yml index ae363af1689..8e79c8d61ee 100644 --- a/.github/workflows/gates_report_brillig.yml +++ b/.github/workflows/gates_report_brillig.yml @@ -1,4 +1,4 @@ -name: Report Brillig opcodes diff +name: Report Brillig bytecode size diff on: push: @@ -42,7 +42,7 @@ jobs: path: ./dist/* retention-days: 3 - compare_brillig_opcode_reports: + compare_brillig_bytecode_size_reports: needs: [build-nargo] runs-on: ubuntu-latest permissions: @@ -65,26 +65,26 @@ jobs: export PATH="$PATH:$(dirname $nargo_binary)" nargo -V - - name: Generate Brillig opcodes report + - name: Generate Brillig bytecode size report working-directory: ./test_programs run: | chmod +x gates_report_brillig.sh ./gates_report_brillig.sh mv gates_report_brillig.json ../gates_report_brillig.json - - name: Compare Brillig opcode reports - id: gates_diff + - name: Compare Brillig bytecode size reports + id: brillig_bytecode_diff uses: noir-lang/noir-gates-diff@93e4cae1229d669de61f0ac76d32e47cefe4adcc with: report: gates_report_brillig.json header: | # Changes to Brillig byte code sizes - summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) + summaryQuantile: 0.9 # only display the 10% most significant bytecode size diffs in the summary (defaults to 20%) - - name: Add gates diff to sticky comment + - name: Add bytecode size diff to sticky comment if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' uses: marocchino/sticky-pull-request-comment@v2 with: - # delete the comment in case changes no longer impact circuit sizes - delete: ${{ !steps.gates_diff.outputs.markdown }} - message: ${{ steps.gates_diff.outputs.markdown }} \ No newline at end of file + # delete the comment in case changes no longer impact brillig bytecode sizes + delete: ${{ !steps.brillig_bytecode_diff.outputs.markdown }} + message: ${{ steps.brillig_bytecode_diff.outputs.markdown }} \ No newline at end of file From 63b3d027f613040a99b86a567e09e83d57de73b8 Mon Sep 17 00:00:00 2001 From: Maxim Vezenov Date: Fri, 16 Aug 2024 21:09:19 +0000 Subject: [PATCH 3/3] update commit --- .github/workflows/gates_report_brillig.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gates_report_brillig.yml b/.github/workflows/gates_report_brillig.yml index 8e79c8d61ee..d8d4d514169 100644 --- a/.github/workflows/gates_report_brillig.yml +++ b/.github/workflows/gates_report_brillig.yml @@ -74,11 +74,11 @@ jobs: - name: Compare Brillig bytecode size reports id: brillig_bytecode_diff - uses: noir-lang/noir-gates-diff@93e4cae1229d669de61f0ac76d32e47cefe4adcc + uses: noir-lang/noir-gates-diff@cd8721ebe0ad9a67889c601063cccc33a8ca7f32 with: report: gates_report_brillig.json header: | - # Changes to Brillig byte code sizes + # Changes to Brillig bytecode sizes summaryQuantile: 0.9 # only display the 10% most significant bytecode size diffs in the summary (defaults to 20%) - name: Add bytecode size diff to sticky comment