From b1c6d0bcbaafa95b3f5be4c4e71c1fa35e7dca57 Mon Sep 17 00:00:00 2001 From: Koby Date: Sat, 7 Oct 2023 10:47:48 +0200 Subject: [PATCH 1/8] chore: add nightly script to packages --- acvm-repo/acvm_js/package.json | 1 + compiler/source-resolver/package.json | 1 + compiler/wasm/package.json | 1 + tooling/noir_js/package.json | 1 + tooling/noir_js_backend_barretenberg/package.json | 1 + tooling/noir_js_types/package.json | 1 + tooling/noirc_abi_wasm/package.json | 1 + 7 files changed, 7 insertions(+) diff --git a/acvm-repo/acvm_js/package.json b/acvm-repo/acvm_js/package.json index f7d2bf08a1a..e7de149ec5c 100644 --- a/acvm-repo/acvm_js/package.json +++ b/acvm-repo/acvm_js/package.json @@ -28,6 +28,7 @@ "test:browser": "web-test-runner", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "clean": "chmod u+w web nodejs || true && rm -rf web nodejs" }, "devDependencies": { diff --git a/compiler/source-resolver/package.json b/compiler/source-resolver/package.json index 2e44246beab..7a5f29f5584 100644 --- a/compiler/source-resolver/package.json +++ b/compiler/source-resolver/package.json @@ -24,6 +24,7 @@ "test": "ava", "generate-types": "tsc src/*.ts --declaration --emitDeclarationOnly --outDir types", "clean": "rm -rf ./lib ./lib-node", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0" }, diff --git a/compiler/wasm/package.json b/compiler/wasm/package.json index 446a189302b..00dcb8f046a 100644 --- a/compiler/wasm/package.json +++ b/compiler/wasm/package.json @@ -24,6 +24,7 @@ "test:node": "env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha", "test:browser": "web-test-runner", "clean": "chmod u+w web nodejs || true && rm -rf ./nodejs ./web ./target ./result", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0" }, diff --git a/tooling/noir_js/package.json b/tooling/noir_js/package.json index 2bd7570830a..6ad839fb993 100644 --- a/tooling/noir_js/package.json +++ b/tooling/noir_js/package.json @@ -35,6 +35,7 @@ "prettier": "prettier 'src/**/*.ts'", "prettier:fix": "prettier --write 'src/**/*.ts' 'test/**/*.ts'", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", "clean": "rm -rf ./lib" }, diff --git a/tooling/noir_js_backend_barretenberg/package.json b/tooling/noir_js_backend_barretenberg/package.json index 4bac7cb4ccd..9ef1ae143ab 100644 --- a/tooling/noir_js_backend_barretenberg/package.json +++ b/tooling/noir_js_backend_barretenberg/package.json @@ -27,6 +27,7 @@ "clean": "rm -rf ./lib", "prettier": "prettier 'src/**/*.ts'", "prettier:fix": "prettier --write 'src/**/*.ts' 'test/**/*.ts'", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0" }, diff --git a/tooling/noir_js_types/package.json b/tooling/noir_js_types/package.json index d9f64ae9b31..eb913f16ca3 100644 --- a/tooling/noir_js_types/package.json +++ b/tooling/noir_js_types/package.json @@ -17,6 +17,7 @@ "build:esm": "tsc", "build:cjs": "tsc --module CommonJS --outDir lib/cjs", "build": "yarn run build:cjs && yarn run build:esm", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0" }, diff --git a/tooling/noirc_abi_wasm/package.json b/tooling/noirc_abi_wasm/package.json index 584539ddbe4..a4e076dd0b6 100644 --- a/tooling/noirc_abi_wasm/package.json +++ b/tooling/noirc_abi_wasm/package.json @@ -26,6 +26,7 @@ "test": "env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha", "test:browser": "web-test-runner", "clean": "chmod u+w web nodejs || true && rm -rf ./nodejs ./web ./target ./result", + "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json", "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish", "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0" }, From 3a3d73a8566b2dc8cbdf47cefd0af42bd6ecf40e Mon Sep 17 00:00:00 2001 From: Koby Date: Sat, 7 Oct 2023 11:57:36 +0200 Subject: [PATCH 2/8] chore: nightly version script for all members --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 9b7cf4a04b5..42a76f2f549 100644 --- a/package.json +++ b/package.json @@ -31,6 +31,7 @@ "build:noir_js": "yarn workspace @noir-lang/noir_js run build", "build:js:only": "yarn build:types && yarn build:source-resolver && yarn build:backend_barretenberg && yarn build:noir_js", "prepare:publish": "yarn clean && yarn install:from:nix && yarn build:js:only", + "nightly:version": "yarn workspaces foreach run nightly:version", "publish:all": "yarn install && yarn workspaces foreach run publish" }, "devDependencies": { From 1b40af8c1bb214e18ac076682aed027babf01023 Mon Sep 17 00:00:00 2001 From: Koby Date: Sat, 7 Oct 2023 12:11:33 +0200 Subject: [PATCH 3/8] chore: publish nightly to npm --- .github/workflows/publish-es-packages.yml | 29 ++++++++++++++++++++--- .github/workflows/publish-nargo.yml | 11 +++++++++ .github/workflows/release.yml | 3 ++- 3 files changed, 39 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-es-packages.yml b/.github/workflows/publish-es-packages.yml index 7eec3939f8d..b29740d5502 100644 --- a/.github/workflows/publish-es-packages.yml +++ b/.github/workflows/publish-es-packages.yml @@ -2,13 +2,24 @@ name: Publish Noir ES Packages on: workflow_dispatch: - + inputs: + noir-ref: + description: The noir reference to checkout + required: false + nightly: + description: Indicates this is a nightly release + required: false + type: boolean + default: true + jobs: build-noir_wasm: runs-on: ubuntu-latest steps: - name: Checkout sources uses: actions/checkout@v4 + with: + ref: ${{ inputs.noir-ref || 'master' }} - name: Setup Nix uses: ./.github/actions/nix @@ -26,6 +37,8 @@ jobs: steps: - name: Checkout sources uses: actions/checkout@v4 + with: + ref: ${{ inputs.noir-ref || 'master' }} - name: Setup Nix uses: ./.github/actions/nix @@ -43,6 +56,8 @@ jobs: steps: - name: Checkout sources uses: actions/checkout@v4 + with: + ref: ${{ inputs.noir-ref || 'master' }} - name: Setup Nix uses: ./.github/actions/nix @@ -61,6 +76,8 @@ jobs: steps: - name: Checkout sources uses: actions/checkout@v4 + with: + ref: ${{ inputs.noir-ref || 'master' }} - name: Setup Nix uses: ./.github/actions/nix @@ -75,8 +92,14 @@ jobs: - name: Build ES Packages run: yarn prepare:publish + - name: Prepare nightly version + if: ${{ inputs.nightly }} + run: | + sudo apt-get install jq + yarn nightly:version + - name: Authenticate with npm run: "echo npmAuthToken: ${{ secrets.NPM_TOKEN }} > ~/.yarnrc.yml" - + - name: Publish ES Packages - run: yarn publish:all --access public \ No newline at end of file + run: yarn publish:all --access public ${{ inputs.nightly && ' --tag nightly' }} \ No newline at end of file diff --git a/.github/workflows/publish-nargo.yml b/.github/workflows/publish-nargo.yml index 15ed04f3f71..901436d0316 100644 --- a/.github/workflows/publish-nargo.yml +++ b/.github/workflows/publish-nargo.yml @@ -198,3 +198,14 @@ jobs: make_latest: false overwrite: true tag: ${{ format('{0}-{1}', 'nightly', steps.date.outputs.date) }} + + dispatch-publish-es: + runs-on: ubuntu-latest + steps: + - name: Dispatch to publish-es-packages + uses: benc-uk/workflow-dispatch@v1 + with: + workflow: publish-es-packages.yml + ref: master + token: ${{ secrets.NOIR_REPO_TOKEN }} + inputs: "{ \"noir-ref\": \"${{ inputs.tag || env.GITHUB_REF }}\", \"nightly\": ${{ github.event_name == 'schedule' }} }" \ No newline at end of file diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b579061779f..b1c61e2a5c4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -71,9 +71,10 @@ jobs: if: ${{ needs.release-please.outputs.tag-name }} runs-on: ubuntu-latest steps: - - name: Dispatch to noir_wasm + - name: Dispatch to publish-es-packages uses: benc-uk/workflow-dispatch@v1 with: workflow: publish-es-packages.yml ref: master token: ${{ secrets.NOIR_REPO_TOKEN }} + inputs: '{ "noir-ref": "${{ needs.release-please.outputs.tag-name }}", "nightly": false }' \ No newline at end of file From 36630e89dd027164fbc26b11dbd4a60ea845d335 Mon Sep 17 00:00:00 2001 From: Koby Date: Mon, 9 Oct 2023 15:50:25 +0200 Subject: [PATCH 4/8] chore: clean other build es buid workflows --- .github/workflows/publish-abi_wasm.yml | 51 ------------------ .github/workflows/publish-acvm-js.yml | 51 ------------------ .github/workflows/publish-noir-js.yml | 52 ------------------- .github/workflows/publish-noir-wasm.yml | 47 ----------------- .github/workflows/publish-source-resolver.yml | 30 ----------- 5 files changed, 231 deletions(-) delete mode 100644 .github/workflows/publish-abi_wasm.yml delete mode 100644 .github/workflows/publish-acvm-js.yml delete mode 100644 .github/workflows/publish-noir-js.yml delete mode 100644 .github/workflows/publish-noir-wasm.yml delete mode 100644 .github/workflows/publish-source-resolver.yml diff --git a/.github/workflows/publish-abi_wasm.yml b/.github/workflows/publish-abi_wasm.yml deleted file mode 100644 index c84a8f0688b..00000000000 --- a/.github/workflows/publish-abi_wasm.yml +++ /dev/null @@ -1,51 +0,0 @@ -name: Publish ABI Wasm - -on: - workflow_dispatch: - inputs: - noir-ref: - description: The noir reference to checkout - required: true - -jobs: - noirc-abi-wasm-build: - runs-on: ubuntu-latest - env: - CACHED_PATH: /tmp/nix-cache - - steps: - - name: Checkout sources - uses: actions/checkout@v3 - with: - repository: "noir-lang/noir" - ref: ${{ inputs.noir-ref }} - - - name: Setup Node.js - uses: actions/setup-node@v3 - with: - registry-url: "https://registry.npmjs.org" - node-version: 18.15 - - - uses: cachix/install-nix-action@v22 - with: - nix_path: nixpkgs=channel:nixos-23.05 - github_access_token: ${{ secrets.GITHUB_TOKEN }} - - - name: Build noirc_abi_wasm - run: nix build .#noirc_abi_wasm - - - name: Discover Build Output Path - run: echo "BUILD_OUTPUT_PATH=$(readlink -f ./result/noirc_abi_wasm)" >> $GITHUB_ENV - - - name: Copy Build Output to Temporary Directory - run: | - mkdir temp_publish_dir - cp -r ${{ env.BUILD_OUTPUT_PATH }}/* temp_publish_dir/ - touch temp_publish_dir/yarn.lock - - - name: Publish to NPM - working-directory: ./temp_publish_dir - run: yarn npm publish --tag latest - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} - diff --git a/.github/workflows/publish-acvm-js.yml b/.github/workflows/publish-acvm-js.yml deleted file mode 100644 index 997cdbd565e..00000000000 --- a/.github/workflows/publish-acvm-js.yml +++ /dev/null @@ -1,51 +0,0 @@ -name: Publish acvm-js - -on: - workflow_dispatch: - inputs: - acvm-ref: - description: The acvm reference to checkout - required: true - -jobs: - publish-acvm-js-package: - runs-on: ubuntu-latest - steps: - - name: Checkout sources - uses: actions/checkout@v4 - with: - ref: ${{ inputs.acvm-ref }} - - - name: Setup Node.js - uses: actions/setup-node@v3 - with: - registry-url: "https://registry.npmjs.org" - node-version: 18.15 - - - uses: cachix/install-nix-action@v22 - with: - nix_path: nixpkgs=channel:nixos-23.05 - github_access_token: ${{ secrets.GITHUB_TOKEN }} - - - uses: cachix/cachix-action@v12 - with: - name: barretenberg - authToken: "${{ secrets.CACHIX_AUTH_TOKEN }}" - - - name: Build acvm-js - run: nix build .#acvm_js - - - name: Discover Build Output Path - run: echo "BUILD_OUTPUT_PATH=$(readlink -f ./result/acvm_js)" >> $GITHUB_ENV - - - name: Copy Build Output to Temporary Directory - run: | - mkdir temp_publish_dir - cp -r ${{ env.BUILD_OUTPUT_PATH }}/* temp_publish_dir/ - touch temp_publish_dir/yarn.lock - - - name: Publish to NPM - working-directory: ./temp_publish_dir - run: yarn npm publish --tag latest - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/.github/workflows/publish-noir-js.yml b/.github/workflows/publish-noir-js.yml deleted file mode 100644 index f10f0181fb6..00000000000 --- a/.github/workflows/publish-noir-js.yml +++ /dev/null @@ -1,52 +0,0 @@ -name: Publish Noir Js - -on: - workflow_dispatch: - -jobs: - release-noir-js: - name: Release and Publish Noir Js - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Install dependencies - run: yarn install --immutable - - - name: Install jq - run: sudo apt-get install jq - - - name: Setup toolchain - uses: dtolnay/rust-toolchain@1.66.0 - - - name: Install wasm-bindgen-cli - uses: taiki-e/install-action@v2 - with: - tool: wasm-bindgen-cli@0.2.86 - - - name: Install wasm-opt - run: | - npm i wasm-opt -g - - - name: Install wasm32-unknown-unknwown target - run: | - rustup target add wasm32-unknown-unknown - - - name: Build noirc_abi - run: yarn workspace @noir-lang/noirc_abi build - - - name: Build acvm_js - run: yarn workspace @noir-lang/acvm_js build - - - name: Build noir_js - run: yarn workspace @noir-lang/noir_js build - - - name: Authenticate with npm - run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc - - - name: Publish to NPM - working-directory: ./tooling/noir_js - run: yarn npm publish --access public - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/.github/workflows/publish-noir-wasm.yml b/.github/workflows/publish-noir-wasm.yml deleted file mode 100644 index c434fa5077a..00000000000 --- a/.github/workflows/publish-noir-wasm.yml +++ /dev/null @@ -1,47 +0,0 @@ -name: Publish Noir Wasm - -on: - workflow_dispatch: - -jobs: - publish-noir-wasm: - runs-on: ubuntu-22.04 - - steps: - - name: Checkout - uses: actions/checkout@v3 - - - uses: actions/cache@v3 - with: - path: | - ~/.cargo/bin/ - ~/.cargo/registry/index/ - ~/.cargo/registry/cache/ - ~/.cargo/git/db/ - target/ - key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} - - - uses: cachix/install-nix-action@v22 - with: - nix_path: nixpkgs=channel:nixos-23.05 - - - name: Build with Nix - run: nix build .#noir_wasm - - - name: Discover Build Output Path - run: echo "BUILD_OUTPUT_PATH=$(readlink -f ./result/noir_wasm)" >> $GITHUB_ENV - - - name: Copy Build Output to Temporary Directory - run: | - mkdir temp_publish_dir - cp -r ${{ env.BUILD_OUTPUT_PATH }}/* temp_publish_dir/ - touch temp_publish_dir/yarn.lock - - - name: Authenticate with npm - run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc - - - name: Publish to NPM - working-directory: ./temp_publish_dir - run: yarn npm publish --tag latest - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/.github/workflows/publish-source-resolver.yml b/.github/workflows/publish-source-resolver.yml deleted file mode 100644 index 399e72a7b96..00000000000 --- a/.github/workflows/publish-source-resolver.yml +++ /dev/null @@ -1,30 +0,0 @@ -name: Publish Source Resolver - -on: - workflow_dispatch: - -jobs: - release-source-resolver: - name: Publish Source Resolver - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Setup Node.js - uses: actions/setup-node@v3 - with: - registry-url: "https://registry.npmjs.org" - node-version: 18.15 - - - name: Install dependencies - run: yarn install --immutable - - - name: Build noir-source-resolver - run: yarn workspace @noir-lang/source-resolver build - - - name: Publish to NPM - working-directory: ./compiler/source-resolver - run: yarn npm publish - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} From d06517d6dabb43a0299c0fed9984e2cb809143b1 Mon Sep 17 00:00:00 2001 From: Tom French Date: Mon, 9 Oct 2023 15:33:14 +0100 Subject: [PATCH 5/8] chore: add single entrypoint workflow for creating a nightly release --- .github/workflows/publish-nargo.yml | 22 ++++++--------------- .github/workflows/publish-nightly.yml | 28 +++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 16 deletions(-) create mode 100644 .github/workflows/publish-nightly.yml diff --git a/.github/workflows/publish-nargo.yml b/.github/workflows/publish-nargo.yml index 901436d0316..6d8eef03fe9 100644 --- a/.github/workflows/publish-nargo.yml +++ b/.github/workflows/publish-nargo.yml @@ -14,9 +14,6 @@ on: description: Whether to publish the build artifacts type: boolean default: false - schedule: - # Run a nightly release at 2 AM UTC - - cron: "0 2 * * *" merge_group: pull_request: @@ -29,6 +26,7 @@ jobs: runs-on: macos-latest env: CROSS_CONFIG: ${{ github.workspace }}/.github/Cross.toml + NIGHTLY_RELEASE: ${{ inputs.tag == "" }} strategy: matrix: target: [x86_64-apple-darwin, aarch64-apple-darwin] @@ -117,6 +115,7 @@ jobs: runs-on: ubuntu-22.04 env: CROSS_CONFIG: ${{ github.workspace }}/.github/Cross.toml + NIGHTLY_RELEASE: ${{ inputs.tag == "" }} strategy: fail-fast: false matrix: @@ -172,7 +171,7 @@ jobs: - name: Upload binaries to release tag uses: svenstaro/upload-release-action@v2 - if: ${{ inputs.publish || github.event_name == 'schedule' }} + if: ${{ inputs.publish }} with: repo_name: noir-lang/noir repo_token: ${{ secrets.GITHUB_TOKEN }} @@ -183,12 +182,12 @@ jobs: - name: Get formatted date id: date - if: ${{ inputs.tag == '' && inputs.publish || github.event_name == 'schedule' }} + if: ${{ env.NIGHTLY_RELEASE && inputs.publish }} run: echo "date=$(date '+%Y-%m-%d')" >> $GITHUB_OUTPUT - name: Upload binaries to release with date tag uses: svenstaro/upload-release-action@v2 - if: ${{ inputs.tag == '' && inputs.publish || github.event_name == 'schedule' }} + if: ${{ env.NIGHTLY_RELEASE && inputs.publish }} with: repo_name: noir-lang/noir repo_token: ${{ secrets.GITHUB_TOKEN }} @@ -199,13 +198,4 @@ jobs: overwrite: true tag: ${{ format('{0}-{1}', 'nightly', steps.date.outputs.date) }} - dispatch-publish-es: - runs-on: ubuntu-latest - steps: - - name: Dispatch to publish-es-packages - uses: benc-uk/workflow-dispatch@v1 - with: - workflow: publish-es-packages.yml - ref: master - token: ${{ secrets.NOIR_REPO_TOKEN }} - inputs: "{ \"noir-ref\": \"${{ inputs.tag || env.GITHUB_REF }}\", \"nightly\": ${{ github.event_name == 'schedule' }} }" \ No newline at end of file + \ No newline at end of file diff --git a/.github/workflows/publish-nightly.yml b/.github/workflows/publish-nightly.yml new file mode 100644 index 00000000000..1d00a044c78 --- /dev/null +++ b/.github/workflows/publish-nightly.yml @@ -0,0 +1,28 @@ +name: Publish Nightly release +on: + workflow_dispatch: + schedule: + # Run a nightly release at 2 AM UTC + - cron: "0 2 * * *" + +jobs: + dispatch-publish-es: + runs-on: ubuntu-latest + steps: + - name: Dispatch to publish-nargo + uses: benc-uk/workflow-dispatch@v1 + with: + workflow: publish-nargo.yml + ref: master + token: ${{ secrets.NOIR_REPO_TOKEN }} + # Omitting a tag results in a nightly + inputs: "{ \"publish\": true }" + + + - name: Dispatch to publish-es-packages + uses: benc-uk/workflow-dispatch@v1 + with: + workflow: publish-es-packages.yml + ref: master + token: ${{ secrets.NOIR_REPO_TOKEN }} + inputs: "{ \"noir-ref\": \"${{ env.GITHUB_REF }}\", \"nightly\": true }" From e341be26a99fec50825d5596dda8d4450ae0a370 Mon Sep 17 00:00:00 2001 From: Koby Date: Mon, 9 Oct 2023 16:47:17 +0200 Subject: [PATCH 6/8] chore: remove master ref --- .github/workflows/publish-nightly.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/publish-nightly.yml b/.github/workflows/publish-nightly.yml index 1d00a044c78..9e8299bc597 100644 --- a/.github/workflows/publish-nightly.yml +++ b/.github/workflows/publish-nightly.yml @@ -13,7 +13,6 @@ jobs: uses: benc-uk/workflow-dispatch@v1 with: workflow: publish-nargo.yml - ref: master token: ${{ secrets.NOIR_REPO_TOKEN }} # Omitting a tag results in a nightly inputs: "{ \"publish\": true }" @@ -23,6 +22,5 @@ jobs: uses: benc-uk/workflow-dispatch@v1 with: workflow: publish-es-packages.yml - ref: master token: ${{ secrets.NOIR_REPO_TOKEN }} inputs: "{ \"noir-ref\": \"${{ env.GITHUB_REF }}\", \"nightly\": true }" From 830899008bda7d96d42fc6ab641e95834646634e Mon Sep 17 00:00:00 2001 From: Tom French Date: Mon, 9 Oct 2023 16:20:33 +0100 Subject: [PATCH 7/8] chore: fix workflow file --- .github/workflows/publish-nargo.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-nargo.yml b/.github/workflows/publish-nargo.yml index 6d8eef03fe9..2f3791fa83f 100644 --- a/.github/workflows/publish-nargo.yml +++ b/.github/workflows/publish-nargo.yml @@ -26,7 +26,7 @@ jobs: runs-on: macos-latest env: CROSS_CONFIG: ${{ github.workspace }}/.github/Cross.toml - NIGHTLY_RELEASE: ${{ inputs.tag == "" }} + NIGHTLY_RELEASE: ${{ inputs.tag == '' }} strategy: matrix: target: [x86_64-apple-darwin, aarch64-apple-darwin] From 969d23952017feebcfd846113db958c3cdf4261d Mon Sep 17 00:00:00 2001 From: Tom French Date: Mon, 9 Oct 2023 16:22:25 +0100 Subject: [PATCH 8/8] chore: fix other instance of quote issue --- .github/workflows/publish-nargo.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-nargo.yml b/.github/workflows/publish-nargo.yml index 2f3791fa83f..fa642de8a4f 100644 --- a/.github/workflows/publish-nargo.yml +++ b/.github/workflows/publish-nargo.yml @@ -115,7 +115,7 @@ jobs: runs-on: ubuntu-22.04 env: CROSS_CONFIG: ${{ github.workspace }}/.github/Cross.toml - NIGHTLY_RELEASE: ${{ inputs.tag == "" }} + NIGHTLY_RELEASE: ${{ inputs.tag == '' }} strategy: fail-fast: false matrix: